fix: sync :duckdb into PRQL.Native.CompileOptions target typespec#5823
Merged
fix: sync :duckdb into PRQL.Native.CompileOptions target typespec#5823
Conversation
PRQL.target() and the NIF's target_from_atom already accept :duckdb (via #5817), but PRQL.Native.CompileOptions.target() was missed — Dialyzer would flag target: :duckdb on the struct despite the runtime accepting it. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PRQL.target()inlib/prql.ex(the public Elixir type) lists:duckdbamong accepted dialects, and the NIF innative/prql/src/lib.rsmaps theduckdbatom toDialect::DuckDb. However,PRQL.Native.CompileOptions.target()inlib/prql/native.ex— the struct that actually carries the dialect into the NIF — was missing:duckdb.This was a leftover from #5817 (which added DuckDB to the public type spec and the Rust NIF but not to the internal struct spec). Dialyzer would flag setting
target: :duckdbon the compile options struct, even though the runtime accepts it.#5821 (Oracle) correctly updated all three files; this PR syncs the one spec #5817 missed.
Test plan
test-elixir) still pass on CI