internal: remove redundant bare use chumsky; self-import#5846
Merged
Conversation
max-sixty
deleted the
internal/remove-redundant-chumsky-import-25039216867
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prqlc/prqlc-parser/src/parser/types.rs:1had a bareuse chumsky;self-import on its own line, immediately followed by the actually-neededuse chumsky::input::BorrowInput;. Sincechumskyis a crate in this crate's dependency tree, it is always reachable aschumsky::...without ausestatement; the bareuse chumsky;pulls the same name into local scope but nothing in the file references it as the bare identifier. Removing it leaves the file unchanged in behavior.Found during the nightly survey of
prqlc-parser/src/parser/types.rs.cargo build -p prqlc-parserandcargo clippy -p prqlc-parserboth pass after the change.No regression test — the change is a pure import cleanup with no observable behavior.