Skip to content

feat(ui): add new storage buildings#346

Merged
jplacht merged 5 commits intoPRUNplanner:mainfrom
theit8514:feature/new-storages
Mar 1, 2026
Merged

feat(ui): add new storage buildings#346
jplacht merged 5 commits intoPRUNplanner:mainfrom
theit8514:feature/new-storages

Conversation

@theit8514
Copy link
Copy Markdown
Contributor

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 28, 2026

‼️ Deploy request for prunplanner-preview rejected.

Name Link
🔨 Latest commit 4253fd4

@jplacht
Copy link
Copy Markdown
Contributor

jplacht commented Feb 28, 2026

@theit8514 thank you, great start! Could you please have a look at the failed workflows? I see linting, type checking and tests failing.

You can also run all of them locally, the commands are in package.json - Thank you!

@theit8514
Copy link
Copy Markdown
Contributor Author

Fixed the linting errors. I wasn't aware of the knip, tsc, or lint commands. Perhaps these could be added to README.md alongside the test commands for future contributors?

As for the failing test, adding the additional infrastructure buildings has pushed the test over the 5 second limit on compute time for the test. I tried profiling the test to see if there was something I could do. There's a lot of exceptions being thrown and written to stderr related to the game data not being loaded for exchange data. Unsure if this is because the execution of a single test doesn't load something into the fake-indexeddb or if this is something that should be investigated.

@jplacht
Copy link
Copy Markdown
Contributor

jplacht commented Feb 28, 2026

Fixed the linting errors. I wasn't aware of the knip, tsc, or lint commands. Perhaps these could be added to README.md alongside the test commands for future contributors?

Good idea, will make a note to add a section!

As for the failing test, adding the additional infrastructure buildings has pushed the test over the 5 second limit on compute time for the test. I tried profiling the test to see if there was something I could do. There's a lot of exceptions being thrown and written to stderr related to the game data not being loaded for exchange data. Unsure if this is because the execution of a single test doesn't load something into the fake-indexeddb or if this is something that should be investigated.

That sounds weird. I'll have a look; you added the buildings to the testdata, iirc. Will check it out or otherwise pull the JSON again from the backend API.

Could also be another unrelated test case. Some component initialization and router tests were slow already.

@theit8514
Copy link
Copy Markdown
Contributor Author

The new storage components weren't in the test data for exchange preloading. The test should run faster now.

@jplacht
Copy link
Copy Markdown
Contributor

jplacht commented Feb 28, 2026

Awesome, all tests passed. I will have a look tomorrow and probably also put it in the release right away once I played around.

@jplacht jplacht self-requested a review March 1, 2026 15:37
Copy link
Copy Markdown
Contributor

@jplacht jplacht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome work, thank you!

@jplacht jplacht merged commit 7095a8c into PRUNplanner:main Mar 1, 2026
5 of 6 checks passed
@theit8514 theit8514 deleted the feature/new-storages branch March 11, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants