feat(ui): add new storage buildings#346
Conversation
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 4253fd4 |
|
@theit8514 thank you, great start! Could you please have a look at the failed workflows? I see linting, type checking and tests failing. You can also run all of them locally, the commands are in |
|
Fixed the linting errors. I wasn't aware of the knip, tsc, or lint commands. Perhaps these could be added to README.md alongside the test commands for future contributors? As for the failing test, adding the additional infrastructure buildings has pushed the test over the 5 second limit on compute time for the test. I tried profiling the test to see if there was something I could do. There's a lot of exceptions being thrown and written to stderr related to the game data not being loaded for exchange data. Unsure if this is because the execution of a single test doesn't load something into the fake-indexeddb or if this is something that should be investigated. |
Good idea, will make a note to add a section!
That sounds weird. I'll have a look; you added the buildings to the testdata, iirc. Will check it out or otherwise pull the JSON again from the backend API. Could also be another unrelated test case. Some component initialization and router tests were slow already. |
|
The new storage components weren't in the test data for exchange preloading. The test should run faster now. |
|
Awesome, all tests passed. I will have a look tomorrow and probably also put it in the release right away once I played around. |
jplacht
left a comment
There was a problem hiding this comment.
LGTM! Awesome work, thank you!
Requested on Discord (https://discord.com/channels/667551433503014924/1472627123675074651)