[CI] Register 5 previously-uncovered tests in pytorchsim_test.yml#233
Merged
Conversation
YWHyuk
force-pushed
the
refactor/tests-ci-coverage
branch
2 times, most recently
from
35c22ee to
ab8aeec
Compare
Adds three top-level jobs (test_eager, test_exponent, test_sort) and two steps inside the test_fusion job (test_attention_fusion, test_matmul_vector). All five were verified locally before registration. Files in tests/ that remain intentionally out of CI: - test_gqa.py, test_gqa_decode.py: WIP GQA SDPA path, tracked by issue #198 - test_sdpa.py: overlaps with in-flight SDPA template work; ambiguous about which backend it actually exercises - test_topk.py: sort-family coverage now provided by test_sort (stable + unstable + duplicate-key); revisit if topk-specific shapes need gating - test_group_conv.py: not run locally yet (stress config); follow-up after runtime cost is understood - test_vectorops.py: imports from other tests (test_add, test_activation, test_reduce, test_layernorm, test_softmax) which is fragile; needs an independent helper extraction before going into CI Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
YWHyuk
force-pushed
the
refactor/tests-ci-coverage
branch
from
ab8aeec to
af3b8b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds five
tests/files that previously existed in the repo but were not in the CI allowlist, locally verified before registration:tests/test_eager.pytest_eagertests/test_exponent.pytest_exponenttests/test_sort.pytest_sorttests/Fusion/test_attention_fusion.pytest_fusionjobtests/Fusion/test_matmul_vector.pytest_fusionjobAll five were run locally against
origin/developand passed.Intentionally deferred
tests/test_gqa.py,tests/test_gqa_decode.pytests/test_sdpa.pytests/test_topk.pytest_sort(stable + unstable + duplicate-key); revisit if topk-specific shapes/dims need separate gatingtests/test_group_conv.pytests/test_vectorops.pyfrom tests.test_add import ...) are fragile; needs a helper-module extraction firstThis closes the most obvious accidental-omission gaps in the allowlist documented in CLAUDE.md (
docs/ci-test-allowlistPR).🤖 Generated with Claude Code