Fix temp dir location for cross-drive hardlink failures on Windows#15
Merged
Merged
Conversation
On Windows, hardlinks cannot cross drives (WinError 17) and symlinks require the 'Create Symbolic Links' privilege (WinError 1314), which most users lack. Previously, when the source file and temp folder were on different drives, both linking strategies would fail. Detect cross-drive scenarios by comparing st_dev of source and temp folder. When they differ, create the staging directory next to the source file so the hardlink succeeds. When on the same drive, respect the user's temp_folder preference.
RenanGBarreto
approved these changes
Jun 3, 2026
Contributor
|
Thank you very much for the PR, @cherryduck . I will merge it and soon I will release a new version of mkpfs with this bugfix. |
RenanGBarreto
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, hardlinks cannot cross drives (WinError 17) and symlinks require the 'Create Symbolic Links' privilege (WinError 1314), which most users lack. Previously, when the source file and temp folder were on different drives, both linking strategies would fail.
Detect cross-drive scenarios by comparing st_dev of source and temp folder. When they differ, create the staging directory next to the source file so the hardlink succeeds. When on the same drive, respect the user's temp_folder preference.