fix(cli): default min-compress-size to resolved block size#32
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates MkPFS’s CLI packing behavior so that when --min-compress-size is omitted (or provided as 0), it defaults to the resolved block size being used for the build (including auto and auto-fit cases). This aligns PFSC compression skipping with the effective logical block size to avoid wasting effort/compression overhead on sub-block-sized payloads.
Changes:
- Update CLI pack config resolution to map
min_compress_size=0to the resolvedblock_size. - Extend CLI test coverage to assert the derived
min_compress_sizeforautoandauto-fitflows (including single-file streaming vs fallback). - Refresh README option docs and a minor formatting cleanup in the limitations section.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/mkpfs/test_cli.py | Adds assertions/tests confirming min_compress_size defaults to the resolved block size across relevant CLI paths. |
| README.md | Documents the new --min-compress-size defaulting behavior and fixes a small formatting issue. |
| mkpfs/cli.py | Implements the derived min_compress_size resolution (0 → resolved block_size) and updates CLI help text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.