Skip to content

Increase the maximum for init_guess_TR_SS#1040

Merged
jdebacker merged 2 commits intoPSLmodels:masterfrom
rickecon:init_tr
Jul 9, 2025
Merged

Increase the maximum for init_guess_TR_SS#1040
jdebacker merged 2 commits intoPSLmodels:masterfrom
rickecon:init_tr

Conversation

@rickecon
Copy link
Copy Markdown
Member

@rickecon rickecon commented Jul 8, 2025

This PR increases the maximum value of init_guess_TR_SS in the default_parameters.json file. The current maximum is 0.2. However, this variable is in model units and is not a percentage. As such, its values in the SS can be significantly bigger than 0.2. This is the case in OG-PHL. The maximum value of 2.5 to which I changed it is arbitrary. We may need to increase this value from time-to-time.

cc: @jdebacker

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.67%. Comparing base (1a943f4) to head (4d911d2).
⚠️ Report is 294 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1040   +/-   ##
=======================================
  Coverage   72.67%   72.67%           
=======================================
  Files          20       20           
  Lines        5068     5068           
=======================================
  Hits         3683     3683           
  Misses       1385     1385           
Flag Coverage Δ
unittests 72.67% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ogcore/__init__.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jdebacker jdebacker merged commit ccbf225 into PSLmodels:master Jul 9, 2025
8 checks passed
@rickecon rickecon deleted the init_tr branch July 9, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants