Skip to content

Move param labels#1097

Merged
rickecon merged 10 commits intoPSLmodels:masterfrom
jdebacker:param_labels
Apr 3, 2026
Merged

Move param labels#1097
rickecon merged 10 commits intoPSLmodels:masterfrom
jdebacker:param_labels

Conversation

@jdebacker
Copy link
Copy Markdown
Member

This PR moves the short descriptions and parameter symbols from ogcore.constants.PARAM_LABELS to default_parameters.json so all the parameter metadata is in one place.

Functions formerly using PARAM_LABELS are updated for this change.

@jdebacker jdebacker requested a review from rickecon April 2, 2026 01:58
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.98%. Comparing base (dbe0b9f) to head (839305f).

Files with missing lines Patch % Lines
ogcore/parameter_tables.py 92.85% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1097      +/-   ##
==========================================
- Coverage   73.20%   72.98%   -0.23%     
==========================================
  Files          21       21              
  Lines        5180     5189       +9     
==========================================
- Hits         3792     3787       -5     
- Misses       1388     1402      +14     
Flag Coverage Δ
unittests 72.98% <93.33%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ogcore/__init__.py 100.00% <100.00%> (ø)
ogcore/constants.py 100.00% <ø> (ø)
ogcore/parameter_tables.py 86.51% <92.85%> (+0.44%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@rickecon rickecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdebacker. This PR looks good. I am just reviewing the content in default_parameters.json.

@rickecon
Copy link
Copy Markdown
Member

rickecon commented Apr 3, 2026

@jdebacker. This looks great. Merging now.

@rickecon rickecon merged commit bfe4c5b into PSLmodels:master Apr 3, 2026
8 checks passed
@rickecon
Copy link
Copy Markdown
Member

rickecon commented Apr 3, 2026

@jdebacker. I ran the run_ogcore_example.py example script on my new MacBook Pro with the M5 Max chip set, and the baseline steady-state and TPI ran in 14 minutes 33.4 seconds, and the reform steady-state and TPI ran in 16 minutes and 40.5 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants