Skip to content

fix(local-setup): add FLW product to automation manifest#17

Open
areychana wants to merge 2 commits intoPSMRI:mainfrom
areychana:fix/add-flw-product-to-local-setup
Open

fix(local-setup): add FLW product to automation manifest#17
areychana wants to merge 2 commits intoPSMRI:mainfrom
areychana:fix/add-flw-product-to-local-setup

Conversation

@areychana
Copy link
Copy Markdown

@areychana areychana commented Apr 25, 2026

📋 Description

JIRA ID: N/A

FLW-API was already registered in lib/services.conf with its repo URL,
port (8081), and properties file, but there was no [flw] entry in
lib/products.conf. This meant running bash start.sh --product=flw
didn't work for anyone trying to set up the FLW module locally.

Added flw to PRODUCT_APIS, PRODUCT_UIS, PRODUCT_DESC, and PRODUCT_ORDER.
Dependencies were sourced from FLW-API's common_example.properties which
references tm-url and fhir-url.

Closes PSMRI/AMRIT#140


✅ Type of Change

  • 🐞 Bug fix (non-breaking change which resolves an issue)

ℹ️ Additional Information

Verified the dependency chain by checking
FLW-API/src/main/environment/common_example.properties directly.
No existing tests are affected by this change.

Summary by CodeRabbit

  • New Features
    • Added support for the Front Line Workers product with associated backend service integrations and updated system configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 25, 2026

Warning

Rate limit exceeded

@areychana has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 48 minutes and 1 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 48 minutes and 1 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f0bfd314-30f4-4bb3-912f-ad0e135cdd7e

📥 Commits

Reviewing files that changed from the base of the PR and between 3689319 and e3ffb86.

📒 Files selected for processing (1)
  • amrit-local-setup/automation/lib/products.conf
📝 Walkthrough

Walkthrough

Adds a new flw product entry to the automation configuration with dependencies on Common, Identity, BeneficiaryID, FLW, TM, Scheduler, and FHIR APIs, sets its UI to empty, defines it as "Front Line Workers," and updates the canonical product order to include it.

Changes

Cohort / File(s) Summary
FLW Product Configuration
amrit-local-setup/automation/lib/products.conf
Added flw entry to PRODUCT_APIS with seven service dependencies (Common-API, Identity-API, BeneficiaryID-Generation-API, FLW-API, TM-API, Scheduler-API, FHIR-API), set PRODUCT_UIS to empty string, added PRODUCT_DESC as "Front Line Workers", and appended flw to PRODUCT_ORDER after hl1097.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related issues

Poem

🐰 A rabbit hops with glee, for FLW at last is free!
No longer lost in config night, the product path now shines so bright.
In automation's gentle fold, a field-line story now is told! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: adding the FLW product to the automation manifest in the local setup configuration.
Linked Issues check ✅ Passed The PR fully addresses all coding requirements from issue #140: adds flw to PRODUCT_APIS with correct dependencies, PRODUCT_UIS, PRODUCT_DESC, and PRODUCT_ORDER.
Out of Scope Changes check ✅ Passed All changes are directly scoped to resolving issue #140; only the products.conf file was modified to add the missing FLW product entry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
amrit-local-setup/automation/lib/products.conf (2)

14-14: Doc comment understates the dependency set vs. the actual API list.

The inline note on Line 14 lists FLW's direct property anchors as tm-url + fhir-urlCommon + Identity + BeneficiaryID + FLW + TM + Scheduler + FHIR, but Scheduler-API is not derived from FLW's own common_example.properties (per the PR description). It is included on Line 24 because TM-API itself needs Scheduler-API (matching the tm/mmu/hwc entries, since resolve_apis in launchers.sh does not resolve transitively). That's the right call — but the comment makes it look as if scheduler-url is referenced by FLW directly. Consider tightening the note so the rationale is unambiguous.

📝 Proposed doc tweak
-#   FLW     → common_example.properties: tm-url + fhir-url            → Common + Identity + BeneficiaryID + FLW + TM + Scheduler + FHIR
+#   FLW     → common_example.properties: tm-url + fhir-url            → Common + Identity + BeneficiaryID + FLW + TM + FHIR
+#             (Scheduler-API added transitively because TM-API requires scheduler-url)

Also applies to: 24-24

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@amrit-local-setup/automation/lib/products.conf` at line 14, The doc comment
on the FLW line overstates direct dependencies: update the inline note for the
FLW entry (the comment referencing "tm-url + fhir-url → Common + Identity +
BeneficiaryID + FLW + TM + Scheduler + FHIR") to clarify that Scheduler-API is a
transitive dependency pulled in via TM-API rather than a direct anchor in FLW's
common_example.properties; reference the FLW entry, its tm-url/fhir-url anchors,
and explain that launchers.sh::resolve_apis resolves TM→Scheduler transitively
so the comment should state "Scheduler (via TM-API)" or similar to avoid
implying a direct scheduler-url in FLW.

35-35: No FLW-UI service is registered in this repository; the empty PRODUCT_UIS[flw]="" is correct.

The search found no FLW-UI service defined in services.conf or elsewhere. Leaving PRODUCT_UIS[flw]="" is the right choice since FLW integrations here are API-only. Adding a brief inline comment (e.g., [flw]="" # API-only, no UI launcher) would clarify this for future maintainers and prevent mistaking it for an oversight.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@amrit-local-setup/automation/lib/products.conf` at line 35, PRODUCT_UIS[flw]
(the line [flw]="" in the products.conf diff) is intentionally empty because
there is no FLW-UI service; update that line to include a short inline comment
clarifying this (e.g., "API-only, no UI launcher") so future maintainers don't
treat it as an omission—locate the [flw]="" entry (PRODUCT_UIS[flw]) and append
a brief comment explaining it's API-only.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@amrit-local-setup/automation/lib/products.conf`:
- Line 14: The doc comment on the FLW line overstates direct dependencies:
update the inline note for the FLW entry (the comment referencing "tm-url +
fhir-url → Common + Identity + BeneficiaryID + FLW + TM + Scheduler + FHIR") to
clarify that Scheduler-API is a transitive dependency pulled in via TM-API
rather than a direct anchor in FLW's common_example.properties; reference the
FLW entry, its tm-url/fhir-url anchors, and explain that
launchers.sh::resolve_apis resolves TM→Scheduler transitively so the comment
should state "Scheduler (via TM-API)" or similar to avoid implying a direct
scheduler-url in FLW.
- Line 35: PRODUCT_UIS[flw] (the line [flw]="" in the products.conf diff) is
intentionally empty because there is no FLW-UI service; update that line to
include a short inline comment clarifying this (e.g., "API-only, no UI
launcher") so future maintainers don't treat it as an omission—locate the
[flw]="" entry (PRODUCT_UIS[flw]) and append a brief comment explaining it's
API-only.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: beef5b90-fa36-4483-8279-f7f5b70ef835

📥 Commits

Reviewing files that changed from the base of the PR and between da401a9 and 3689319.

📒 Files selected for processing (1)
  • amrit-local-setup/automation/lib/products.conf

[tm]="TM-UI"
[hl104]="Helpline104-UI"
[hl1097]="Helpline1097-UI"
[flw]="" # API-only, no UI launcher
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this empty declaration needed?

Copy link
Copy Markdown
Member

@drtechie drtechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor comment @areychana.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AMRIT-DevOps] FLW product missing from local setup automation

2 participants