fix(local-setup): add FLW product to automation manifest#17
fix(local-setup): add FLW product to automation manifest#17areychana wants to merge 2 commits intoPSMRI:mainfrom
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 48 minutes and 1 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
amrit-local-setup/automation/lib/products.conf (2)
14-14: Doc comment understates the dependency set vs. the actual API list.The inline note on Line 14 lists FLW's direct property anchors as
tm-url + fhir-url→Common + Identity + BeneficiaryID + FLW + TM + Scheduler + FHIR, butScheduler-APIis not derived from FLW's owncommon_example.properties(per the PR description). It is included on Line 24 becauseTM-APIitself needsScheduler-API(matching thetm/mmu/hwcentries, sinceresolve_apisinlaunchers.shdoes not resolve transitively). That's the right call — but the comment makes it look as ifscheduler-urlis referenced by FLW directly. Consider tightening the note so the rationale is unambiguous.📝 Proposed doc tweak
-# FLW → common_example.properties: tm-url + fhir-url → Common + Identity + BeneficiaryID + FLW + TM + Scheduler + FHIR +# FLW → common_example.properties: tm-url + fhir-url → Common + Identity + BeneficiaryID + FLW + TM + FHIR +# (Scheduler-API added transitively because TM-API requires scheduler-url)Also applies to: 24-24
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@amrit-local-setup/automation/lib/products.conf` at line 14, The doc comment on the FLW line overstates direct dependencies: update the inline note for the FLW entry (the comment referencing "tm-url + fhir-url → Common + Identity + BeneficiaryID + FLW + TM + Scheduler + FHIR") to clarify that Scheduler-API is a transitive dependency pulled in via TM-API rather than a direct anchor in FLW's common_example.properties; reference the FLW entry, its tm-url/fhir-url anchors, and explain that launchers.sh::resolve_apis resolves TM→Scheduler transitively so the comment should state "Scheduler (via TM-API)" or similar to avoid implying a direct scheduler-url in FLW.
35-35: No FLW-UI service is registered in this repository; the emptyPRODUCT_UIS[flw]=""is correct.The search found no FLW-UI service defined in services.conf or elsewhere. Leaving
PRODUCT_UIS[flw]=""is the right choice since FLW integrations here are API-only. Adding a brief inline comment (e.g.,[flw]="" # API-only, no UI launcher) would clarify this for future maintainers and prevent mistaking it for an oversight.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@amrit-local-setup/automation/lib/products.conf` at line 35, PRODUCT_UIS[flw] (the line [flw]="" in the products.conf diff) is intentionally empty because there is no FLW-UI service; update that line to include a short inline comment clarifying this (e.g., "API-only, no UI launcher") so future maintainers don't treat it as an omission—locate the [flw]="" entry (PRODUCT_UIS[flw]) and append a brief comment explaining it's API-only.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@amrit-local-setup/automation/lib/products.conf`:
- Line 14: The doc comment on the FLW line overstates direct dependencies:
update the inline note for the FLW entry (the comment referencing "tm-url +
fhir-url → Common + Identity + BeneficiaryID + FLW + TM + Scheduler + FHIR") to
clarify that Scheduler-API is a transitive dependency pulled in via TM-API
rather than a direct anchor in FLW's common_example.properties; reference the
FLW entry, its tm-url/fhir-url anchors, and explain that
launchers.sh::resolve_apis resolves TM→Scheduler transitively so the comment
should state "Scheduler (via TM-API)" or similar to avoid implying a direct
scheduler-url in FLW.
- Line 35: PRODUCT_UIS[flw] (the line [flw]="" in the products.conf diff) is
intentionally empty because there is no FLW-UI service; update that line to
include a short inline comment clarifying this (e.g., "API-only, no UI
launcher") so future maintainers don't treat it as an omission—locate the
[flw]="" entry (PRODUCT_UIS[flw]) and append a brief comment explaining it's
API-only.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: beef5b90-fa36-4483-8279-f7f5b70ef835
📒 Files selected for processing (1)
amrit-local-setup/automation/lib/products.conf
| [tm]="TM-UI" | ||
| [hl104]="Helpline104-UI" | ||
| [hl1097]="Helpline1097-UI" | ||
| [flw]="" # API-only, no UI launcher |
There was a problem hiding this comment.
Is this empty declaration needed?
drtechie
left a comment
There was a problem hiding this comment.
LGTM. Minor comment @areychana.
📋 Description
JIRA ID: N/A
FLW-API was already registered in lib/services.conf with its repo URL,
port (8081), and properties file, but there was no [flw] entry in
lib/products.conf. This meant running bash start.sh --product=flw
didn't work for anyone trying to set up the FLW module locally.
Added flw to PRODUCT_APIS, PRODUCT_UIS, PRODUCT_DESC, and PRODUCT_ORDER.
Dependencies were sourced from FLW-API's common_example.properties which
references tm-url and fhir-url.
Closes PSMRI/AMRIT#140
✅ Type of Change
ℹ️ Additional Information
Verified the dependency chain by checking
FLW-API/src/main/environment/common_example.properties directly.
No existing tests are affected by this change.
Summary by CodeRabbit