Feature/faceembedding/changes

[ravishanigarapu]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

• Bug fix
• New feature
• Enhancement
• Refactoring
• Documentation
• Other ( please specify )

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

• Test A
• Test B

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

Release Notes

• New Features

  • Introduced support for biometric data with the addition of faceEmbedding fields in relevant models and controllers.
  • Enhanced call handling with new parameters to track outbound calls and improved data processing for call reports.

• Bug Fixes

  • Corrected driver class name for the secondary data source in configurations.

• Improvements

  • Adjusted synchronization scheduling for CTI data to run every other day.
  • Improved error handling and logging for various services.

• Removals

  • Removed deprecated biometric service interfaces and controllers to streamline functionality.

• Refactor

  • Updated date handling in synchronization processes for better clarity and precision.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces significant modifications across various files, focusing primarily on the management of biometric data and scheduling configurations. Key changes include the addition of fields for face embeddings in several classes, the removal of unused dependencies, and updates to scheduling properties for data synchronization. Additionally, the logic for handling outbound calls and the structure of several service methods have been refined, enhancing the overall functionality of the application.

Changes

Files	Change Summary
pom.xml	Removed dependencies for httpclient and xmlpull, simplifying dependency management.
src/main/environment/common_dev.properties	Updated cron expression for cron-scheduler-ctidatasync to run every alternate day at 2 AM.
src/main/environment/common_test.properties	Added a driver class name for the secondary data source; updated cron expression; removed biometric device URL properties.
src/main/java/com/iemr/common/config/BlockingHttpMethodInterceptor.java	Removed the BlockingHttpMethodInterceptor class, eliminating HTTP method restrictions.
src/main/java/com/iemr/common/config/InterceptorConfig.java	Modified interceptor registration to use HTTPRequestInterceptor instead of BlockingHttpMethodInterceptor.
src/main/java/com/iemr/common/controller/beneficiary/BeneficiaryRegistrationController.java	Updated createBeneficiary method to include a new field for "faceEmbedding" in JSON request body.
src/main/java/com/iemr/common/controller/biometric/BiometricController.java	Removed the BiometricController class, which handled biometric data requests.
src/main/java/com/iemr/common/controller/callhandling/CallController.java	Added an optional parameter "IsOutbound" to the closeCall method for checking outbound call status.
src/main/java/com/iemr/common/controller/carestream/CareStreamCreateOrderController.java	Removed @PropertySource("classpath:myapp.properties"), affecting property access in the controller.
src/main/java/com/iemr/common/controller/nhmdashboard/NHMDetailCallReportScheduler.java	Enhanced logic for processing call reports, including more precise handling of existing records.
src/main/java/com/iemr/common/data/beneficiary/Beneficiary.java	Added a new property faceEmbedding and a corresponding constructor to handle biometric data.
src/main/java/com/iemr/common/dto/identity/CommonIdentityDTO.java	Introduced a new field faceEmbedding to accommodate facial embedding data.
src/main/java/com/iemr/common/repository/report/CallReportRepo.java	Modified method signatures to retrieve detailed call information and added a new method for updating call records.
src/main/java/com/iemr/common/service/beneficiary/IEMRSearchUserServiceImpl.java	Enhanced health ID handling in methods to accommodate different formats.
src/main/java/com/iemr/common/service/beneficiary/RegisterBenificiaryServiceImpl.java	Set faceEmbedding in the CommonIdentityDTO object during the save method.
src/main/java/com/iemr/common/service/biometric/BiometricService.java	Removed the BiometricService interface, eliminating biometric data retrieval functionality.
src/main/java/com/iemr/common/service/biometric/BiometricServiceImpl.java	Removed the BiometricServiceImpl class, which managed biometric data interactions.
src/main/java/com/iemr/common/service/callhandling/BeneficiaryCallServiceImpl.java	Modified methods to include outbound call tracking and refined phone number filtering logic.
src/main/java/com/iemr/common/service/ctiCall/CallCentreDataSyncImpl.java	Updated date handling logic to use LocalDate and LocalDateTime for synchronization processes.
src/main/java/com/iemr/common/service/lungassessment/LungAssessmentService.java	Updated verifyCough method to include a new parameter for temporary file names.
src/main/java/com/iemr/common/service/lungassessment/LungAssessmentServiceImpl.java	Modified exception handling and method signatures to manage temporary file names during cough verification.
src/main/java/com/iemr/common/service/sms/SMSServiceImpl.java	Enhanced address handling in getInstituteData method and updated frequency retrieval logic.

Possibly related PRs

• Added new field for faceEmbeddings #111: This PR adds a new field for face embeddings in the BeneficiaryRegistrationController and Beneficiary classes, which is directly related to the changes in the main PR that involve handling biometric data.
• Added new field for faceEmbedding #112: Similar to Added new field for faceEmbeddings #111, this PR also introduces a new field for face embeddings in the BeneficiaryRegistrationController and Beneficiary classes, reinforcing the connection to the main PR's focus on biometric data management.
• Updated CommonIdentityDTO for faceEmbedding #117: This PR updates the CommonIdentityDTO class to include a faceEmbedding field, aligning with the main PR's changes that involve managing biometric data and enhancing the application's capabilities in this area.

🐰 In the meadow, changes bloom,
New fields for faces, dispel the gloom.
Outbound calls now tracked with care,
Biometric whispers fill the air.
With every hop, our code grows bright,
A rabbit's joy in the soft moonlight! 🌙✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate failed

Failed conditions
3.0% Duplication on New Code (required ≤ 3%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint