Abdm facility id Issue #21
Conversation
…o abdmFacility
…o abdmFacility
…o abdmFacility
WalkthroughThe change updates two methods to retrieve Changes
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
src/registrar/abha-components/health-id-display-modal/health-id-display-modal.component.ts (1)
267-268: Apply the same refactoring suggestions here.The same code duplication and redundant null checking issues apply to the
verifyOtp()method as well.Apply the same refactoring suggestions mentioned for the
generateOtpForMapping()method to eliminate duplication and simplify the null checking logic.Also applies to: 284-285
🧹 Nitpick comments (2)
src/registrar/abha-components/health-id-display-modal/health-id-display-modal.component.ts (2)
195-196: Consider extracting common logic to reduce code duplication.The same logic for retrieving
abdmFacilityIdandabdmFacilityNamefrom session storage is duplicated in bothgenerateOtpForMapping()andverifyOtp()methods.Consider creating a private helper method to retrieve these values:
+ private getAbdmFacilityData() { + return { + abdmFacilityId: this.sessionstorage.getItem("abdmFacilityId"), + abdmFacilityName: this.sessionstorage.getItem("abdmFacilityName") + }; + }Then use it in both methods:
- const abdmFacilityId = this.sessionstorage.getItem("abdmFacilityId"); - const abdmFacilityName = this.sessionstorage.getItem("abdmFacilityName"); + const { abdmFacilityId, abdmFacilityName } = this.getAbdmFacilityData();
205-206: Simplify the null checking logic.The null checking logic is redundant since
sessionStorage.getItem()already returnsnullif the key doesn't exist.Simplify the conditional assignment:
- abdmFacilityId: (abdmFacilityId !== null && abdmFacilityId !== undefined) ? abdmFacilityId : null, - abdmFacilityName: (abdmFacilityName !== null && abdmFacilityName !== undefined) ? abdmFacilityName : null + abdmFacilityId: abdmFacilityId, + abdmFacilityName: abdmFacilityNameOr even more concisely:
- abdmFacilityId: (abdmFacilityId !== null && abdmFacilityId !== undefined) ? abdmFacilityId : null, - abdmFacilityName: (abdmFacilityName !== null && abdmFacilityName !== undefined) ? abdmFacilityName : null + abdmFacilityId, + abdmFacilityName
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/registrar/abha-components/health-id-display-modal/health-id-display-modal.component.ts(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (actions)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
src/registrar/abha-components/health-id-display-modal/health-id-display-modal.component.ts (1)
193-233: LGTM! Functional implementation correctly adds ABDM facility parameters.The implementation correctly adds the required
abdmFacilityIdandabdmFacilityNameparameters to both API request payloads. The changes align with the PR objective of addressing the ABDM facility ID issue and maintain backward compatibility by making these parameters optional.Also applies to: 265-311
📋 Description
JIRA ID:
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit