Skip to content

fix: add missing aria-labels to icon-only controls in ABHA components#47

Open
Aarti-panchal01 wants to merge 1 commit into
PSMRI:mainfrom
Aarti-panchal01:fix/add-aria-labels-abha-components
Open

fix: add missing aria-labels to icon-only controls in ABHA components#47
Aarti-panchal01 wants to merge 1 commit into
PSMRI:mainfrom
Aarti-panchal01:fix/add-aria-labels-abha-components

Conversation

@Aarti-panchal01
Copy link
Copy Markdown

📋 Description

Fixes accessibility violations in ABHA components of Common-UI.
Adds missing aria-labels to all icon-only interactive controls.

Fixes: PSMRI/AMRIT#161

✅ Type of Change

  • 🐞 Bug fix
  • 🎨 UI/UX

ℹ️ Additional Information

Changes:

  • 7 close dialog buttons: added aria-label="Close dialog"
  • 2 password toggles: added aria-label="Toggle password visibility" + converted from plain mat-icon to proper mat-icon-button
  • Total: 9 accessibility violations fixed across 8 files
  • Improves WCAG compliance and screen reader support

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

Warning

Rate limit exceeded

@Aarti-panchal01 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 47 minutes and 34 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 13e9b739-b60f-4b62-9a93-e3b3551e0717

📥 Commits

Reviewing files that changed from the base of the PR and between 5b6fe40 and 4744668.

📒 Files selected for processing (8)
  • src/registrar/abha-components/abha-consent-form/abha-consent-form.component.html
  • src/registrar/abha-components/abha-enter-mobile-otp-component/abha-enter-mobile-otp-component.component.html
  • src/registrar/abha-components/abha-mobile-component/abha-mobile-component.component.html
  • src/registrar/abha-components/biometric-authentication/biometric-authentication.component.html
  • src/registrar/abha-components/display-abha-card/display-abha-card.component.html
  • src/registrar/abha-components/download-search-abha/download-search-abha.component.html
  • src/registrar/abha-components/generate-abha-component/generate-abha-component.component.html
  • src/registrar/abha-components/health-id-display-modal/health-id-display-modal.component.html
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@Aarti-panchal01
Copy link
Copy Markdown
Author

Hi @drtechie and @charantejguniganti

Fixed all 9 accessibility violations identified in #161.

What was fixed:

  • 7 ABHA close dialog buttons: added aria-label="Close dialog"
  • 2 password visibility toggles: added aria-label="Toggle password visibility" + converted from plain mat-icon to semantic mat-icon-button

Why this matters for AMRIT:
ABHA integration is used by frontline health workers including ASHAs and ANMs, many of whom use assistive technologies. Screen reader support on these dialogs was completely broken — a user relying on a screen reader couldn't even close the ABHA dialog or toggle password visibility.

WCAG criteria addressed:

  • 1.1.1 Non-text Content (Level A)
  • 2.1.1 Keyboard accessibility (Level A)
  • 4.1.2 Name, Role, Value (Level A)

Happy to extend this to non-ABHA components (if needed)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessibility: Add missing aria-labels to icon-only controls in ABHA components

1 participant