AMM-1449 | Adding else case for HRP false and call disconnected no#72
Conversation
WalkthroughA new conditional branch was introduced in the outbound call handling logic within Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant CallClosureImpl
Caller->>CallClosureImpl: handleOutboundCall(obj)
alt isHrp is true
CallClosureImpl->>CallClosureImpl: Set call status to OPEN, reset allocation
else isHrp is false and call not disconnected
CallClosureImpl->>CallClosureImpl: Set call status to COMPLETED
end
CallClosureImpl-->>Caller: Return updated call object
Possibly related PRs
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🧬 Code Graph Analysis (1)src/main/java/com/iemr/ecd/service/associate/CallClosureImpl.java (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
drtechie
changed the title
2 participants
📋 Description
JIRA ID: AMM-1449
Adding else case for HRP false and call disconnected no, resolving 4th scenario for HRP
Please provide a summary of the change and the motivation behind it. Include relevant context and details.
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit
IsHrpflag set to false and not disconnected are now correctly marked as "COMPLETED" in their status.