-
Notifications
You must be signed in to change notification settings - Fork 31
Added hapi base and modified hapi fhir dependency #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the project's Maven dependencies in Changes
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pom.xml (1)
193-197: Validate the newly added HAPI Base dependency
Addingca.uhn.hapi:hapi-base:2.6.0could conflict or overlap with other HAPI modules—confirm the correct coordinates and scope.Consider managing HAPI module versions via the official HAPI FHIR BOM in
<dependencyManagement>to prevent version skew.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pom.xml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java)
🔇 Additional comments (2)
pom.xml (2)
189-191: Ensure compatibility with downgraded HAPI FHIR Structures R4
Downgrading from 7.0.2 to 6.10.0 may introduce breaking API changes—verify that all FHIR‐R4 code paths and tests pass against 6.10.0 and review its release notes for regressions.
201-204: Verify the upgraded HL7 FHIR Utilities version
Bumping to 6.5.18 may alter utility behavior—ensure any code relying onorg.hl7.fhir.utilitiesis covered by tests and behaves as expected.
|



📋 Description
JIRA ID: AMM-1452
Removed the jackson dependencies as not required. Modified exisiting fhir-hapi dependencies and added a hapi-base dependency.
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit