-
Notifications
You must be signed in to change notification settings - Fork 48
Cherry-pick health and version API enhancements to release-3.6.1 #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vanitha1822
merged 21 commits into
PSMRI:release-3.6.1
from
DurgaPrasad-54:release-3.6.1
Mar 12, 2026
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
225a698
Add /health endpoint and update /version endpoint
DurgaPrasad-54 e3e0ad2
Update HTTPRequests and fix issues in /health and /version
DurgaPrasad-54 cc3317b
fix(security): validate authentication for /health details
DurgaPrasad-54 62b60fc
feat: update version and health endpoints
DurgaPrasad-54 0a3c8af
fix(redis): fix redis timeout handling issue
DurgaPrasad-54 1b4fb14
fix(health): fix InterruptedException handling and add redis timeout …
DurgaPrasad-54 b5833ed
refactor(health): simplify MySQL health check and remove sensitive de…
DurgaPrasad-54 bf0586c
fix(health): removed unused methods from healthservices
DurgaPrasad-54 e737699
fix(health): remove unused imports
DurgaPrasad-54 def7bc6
fix(health): scope PROCESSLIST lock-wait check to application DB user
DurgaPrasad-54 f23bf9b
fix(health): avoid permanent DEGRADED from historical deadloc
DurgaPrasad-54 ae69b74
fix(health): handle executor rejection during shutdown in /health
DurgaPrasad-54 e95b3d0
refactor(health): centralize component names and fix InterruptedExcep…
DurgaPrasad-54 f949d14
fix(health): resolve remaining reliability issues on new code
DurgaPrasad-54 a2db2ab
fix(health): isolate advanced checks in dedicated executor to avoid t…
DurgaPrasad-54 05960d7
fix(health): cancel timed-out advanced MySQL checks to avoid orphaned…
DurgaPrasad-54 5dc7d1a
fix(health): make advanced MySQL checks interruptible on timeout
DurgaPrasad-54 4eb22ea
fix(health): remove unsafe connection sharing from advanced MySQL checks
DurgaPrasad-54 6d250c7
refactor(health): reduce cognitive complexity of advanced MySQL throt…
DurgaPrasad-54 5efc1e1
fix(health): cancel in-flight futures on generic failure
DurgaPrasad-54 8f1f654
feat(health): add gpl license header
DurgaPrasad-54 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
src/main/java/com/iemr/hwc/controller/health/HealthController.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * AMRIT – Accessible Medical Records via Integrated Technology | ||
| * Integrated EHR (Electronic Health Records) Solution | ||
| * | ||
| * Copyright (C) "Piramal Swasthya Management and Research Institute" | ||
| * | ||
| * This file is part of AMRIT. | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see https://www.gnu.org/licenses/. | ||
| */ | ||
|
|
||
| package com.iemr.hwc.controller.health; | ||
|
|
||
| import java.time.Instant; | ||
| import java.util.Map; | ||
|
DurgaPrasad-54 marked this conversation as resolved.
|
||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
| import org.springframework.http.HttpStatus; | ||
| import org.springframework.http.ResponseEntity; | ||
| import org.springframework.web.bind.annotation.GetMapping; | ||
| import org.springframework.web.bind.annotation.RequestMapping; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
| import com.iemr.hwc.service.health.HealthService; | ||
| import io.swagger.v3.oas.annotations.Operation; | ||
| import io.swagger.v3.oas.annotations.responses.ApiResponse; | ||
| import io.swagger.v3.oas.annotations.responses.ApiResponses; | ||
| import io.swagger.v3.oas.annotations.tags.Tag; | ||
|
|
||
| @RestController | ||
| @RequestMapping("/health") | ||
| @Tag(name = "Health Check", description = "APIs for checking infrastructure health status") | ||
| public class HealthController { | ||
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(HealthController.class); | ||
|
|
||
| private final HealthService healthService; | ||
|
|
||
| public HealthController(HealthService healthService) { | ||
| this.healthService = healthService; | ||
| } | ||
|
|
||
| @GetMapping | ||
| @Operation(summary = "Check infrastructure health", | ||
| description = "Returns the health status of MySQL, Redis, and other configured services") | ||
| @ApiResponses({ | ||
| @ApiResponse(responseCode = "200", description = "Services are UP or DEGRADED (operational with warnings)"), | ||
| @ApiResponse(responseCode = "503", description = "One or more critical services are DOWN") | ||
| }) | ||
| public ResponseEntity<Map<String, Object>> checkHealth() { | ||
| logger.info("Health check endpoint called"); | ||
|
|
||
| try { | ||
| Map<String, Object> healthStatus = healthService.checkHealth(); | ||
| String overallStatus = (String) healthStatus.get("status"); | ||
|
|
||
| // Return 503 only if DOWN; 200 for both UP and DEGRADED (DEGRADED = operational with warnings) | ||
| HttpStatus httpStatus = "DOWN".equals(overallStatus) ? HttpStatus.SERVICE_UNAVAILABLE : HttpStatus.OK; | ||
|
|
||
| logger.debug("Health check completed with status: {}", overallStatus); | ||
| return new ResponseEntity<>(healthStatus, httpStatus); | ||
|
|
||
| } catch (Exception e) { | ||
| logger.error("Unexpected error during health check", e); | ||
|
|
||
| Map<String, Object> errorResponse = Map.of( | ||
| "status", "DOWN", | ||
| "timestamp", Instant.now().toString() | ||
| ); | ||
|
|
||
| return new ResponseEntity<>(errorResponse, HttpStatus.SERVICE_UNAVAILABLE); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is these plugin really required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vanitha1822 Yes, this plugin is required. It generates the git.properties file during the build, which is used by the /version endpoint to expose build metadata such as branch, commit hash, version, and build timestamp.