AMM-1564 Dispense Screen changes #71
Conversation
WalkthroughThe changes shift the disabling of input fields from the template layer to the TypeScript logic in both batch and prescription drug forms. Instead of using Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Template
participant Component TS
participant FormGroup
User->>Template: Loads form
Template->>Component TS: Calls form group initializer
Component TS->>FormGroup: Initializes controls (with disabled states)
FormGroup->>Template: Provides control states
User->>Template: Attempts to interact with inputs
Template->>FormGroup: Forwards input if enabled
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/app/app-modules/core/components/rx-batch-view/rx-batch-view.component.ts (1)
168-171: Simplify the ternary operator and approve the centralized form control approach.The approach of centralizing disabled state in form controls is excellent. However, line 170 contains an unnecessary ternary operator that can be simplified.
Apply this diff to simplify the ternary operator:
- quantity: [{ value: batch.quantity, disabled: selection === 1 ? true : false }], + quantity: [{ value: batch.quantity, disabled: selection === 1 }],🧰 Tools
🪛 Biome (1.9.4)
[error] 170-170: Unnecessary use of boolean literals in conditional expression.
Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with(lint/complexity/noUselessTernary)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/app/app-modules/core/components/rx-batch-view/rx-batch-view.component.html(0 hunks)src/app/app-modules/core/components/rx-batch-view/rx-batch-view.component.ts(1 hunks)src/app/app-modules/rx/rx-item-dispense/rx-item-dispense.component.html(0 hunks)src/app/app-modules/rx/shared/utility/prescribed-drug.utility.ts(1 hunks)
💤 Files with no reviewable changes (2)
- src/app/app-modules/core/components/rx-batch-view/rx-batch-view.component.html
- src/app/app-modules/rx/rx-item-dispense/rx-item-dispense.component.html
🧰 Additional context used
🪛 Biome (1.9.4)
src/app/app-modules/core/components/rx-batch-view/rx-batch-view.component.ts
[error] 170-170: Unnecessary use of boolean literals in conditional expression.
Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with
(lint/complexity/noUselessTernary)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build
🔇 Additional comments (1)
src/app/app-modules/rx/shared/utility/prescribed-drug.utility.ts (1)
47-66: LGTM! Excellent centralization of form control state management.The implementation correctly centralizes disabled state management in the form controls. The selective enabling of
genericDrugName,drugStrength, anddrugIDwhile disabling other fields shows thoughtful consideration of the user interface requirements.
2 participants
📋 Description
JIRA ID: AMM-1564
Added disabled in formGroup
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit