Skip to content

(fix): deleted unnecessary package-prod.yml#76

Merged
drtechie merged 2 commits intoPSMRI:developfrom
abhijeetw035:bugfix/issue-53
Apr 9, 2025
Merged

(fix): deleted unnecessary package-prod.yml#76
drtechie merged 2 commits intoPSMRI:developfrom
abhijeetw035:bugfix/issue-53

Conversation

@abhijeetw035
Copy link
Contributor

@abhijeetw035 abhijeetw035 commented Apr 9, 2025

📋 Description

JIRA ID:

This PR resolves Issue #53.

Deleted unnecessary package-prod.yml


✅ Type of Change

  • 🐞 Bug fix (non-breaking change which resolves an issue)
  • New feature (non-breaking change which adds functionality)
  • 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🛠 Refactor (change that is neither a fix nor a new feature)
  • ⚙️ Config change (configuration file or build script updates)
  • 📚 Documentation (updates to docs or readme)
  • 🧪 Tests (adding new or updating existing tests)
  • 🎨 UI/UX (changes that affect the user interface)
  • 🚀 Performance (improves performance)
  • 🧹 Chore (miscellaneous changes that don't modify src or test files)

ℹ️ Additional Information

Deleted unnecessary package-prod.yml

Summary by CodeRabbit

  • Chores
    • Removed an internal process for production packaging to streamline our deployment pipeline without affecting the end-user experience.
    • Minor formatting adjustments in the build workflow for improved readability.

@coderabbitai
Copy link

coderabbitai bot commented Apr 9, 2025

Walkthrough

The pull request removes a GitHub Actions workflow file that previously automated the production packaging process for the repository. The deleted workflow was triggered on pushes to the master branch and executed steps for setting up Java and Node.js, building the Angular application, and uploading a WAR artifact. Additionally, two blank lines were removed from another workflow file, but no changes were made to any exported or public entities.

Changes

File Path Change Summary
.github/workflows/package-prod.yml Deleted the workflow file named "Package Prod" which ran on Ubuntu. It set up Java (version 17) using AdoptOpenJDK, Node.js (version 18), installed and configured various build tools (Angular CLI, Grunt CLI, TypeScript), executed ng build in production mode, and uploaded a WAR artifact.
.github/workflows/build-on-pull-request.yml Removed two blank lines between the "Set up JDK" and "Set up Node.js" steps in the jobs section.

Sequence Diagram(s)

sequenceDiagram
    participant Dev as Developer
    participant Repo as Repository
    participant CI as GitHub Actions

    Dev->>Repo: Push commit to master branch
    Note over CI: "Package Prod" workflow file deleted  
    CI-->>Dev: No CI packaging process triggered
Loading

Poem

I'm a little rabbit with a codey cheer,
Hopping through commits with joy so clear.
The old workflow's gone, its duties done,
Now quiet paths await under the coding sun.
A hopping celebration 🐇, our repo's lighter, my heart's full of fun!
🎉🚀


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 9, 2025

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/build-on-pull-request.yml (1)

28-28: Remove Trailing Spaces

The diff on line 28 shows trailing whitespace. It’s a small nitpick, but cleaning up extra spaces helps maintain formatting consistency and avoids potential YAML parsing issues in some strict environments.

🧰 Tools
🪛 YAMLlint (1.35.1)

[error] 28-28: trailing spaces

(trailing-spaces)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2277002 and 8eee0ec.

📒 Files selected for processing (1)
  • .github/workflows/build-on-pull-request.yml (1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/build-on-pull-request.yml

[error] 28-28: trailing spaces

(trailing-spaces)

🔇 Additional comments (1)
.github/workflows/build-on-pull-request.yml (1)

42-48: Consistent Formatting of Blank Lines

The removal of superfluous blank lines at the end of the file improves overall file readability. This change is purely cosmetic and helps keep the workflow file tidy.

🧰 Tools
🪛 YAMLlint (1.35.1)

[warning] 44-44: too many blank lines

(4 > 2) (empty-lines)


[error] 45-45: trailing spaces

(trailing-spaces)


[error] 46-46: trailing spaces

(trailing-spaces)


[error] 47-47: trailing spaces

(trailing-spaces)

@drtechie drtechie merged commit 94284be into PSMRI:develop Apr 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C4GT Community]: Ensure GitHub Actions Pass Successfully with Correct Node Version and Submodules in Inventory-UI

2 participants