fix: resolve build warnings in CSS and templates#336
fix: resolve build warnings in CSS and templates#336pragnyanramtha wants to merge 2 commits intoPSMRI:mainfrom
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 7 minutes and 52 seconds.Comment |
There was a problem hiding this comment.
Pull request overview
This PR is described as a fix for Angular/CSS build warnings, but the actual diff only changes TypeScript module-resolution config in tsconfig.json. In the current form, it does not align with the stated purpose of fixing the cited CSS and template warnings.
Changes:
- Added a
pathsmapping forCommon-UI/src/*in the root TypeScript config. - Did not include the CSS/template file edits referenced in the PR description.
- Leaves the intended warning-removal scope unclear because the implementation is config-only.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| style="margin-left: 30px" | ||
| class="mat_blue" | ||
| [disabled]="!viewFiles?.length" | ||
| [disabled]="!viewFiles.length" |
Summary
Fixed CSS warning:
align-items: start→flex-startin abha-consent-form.component.cssRemoved unnecessary optional chaining (?.) operators in gynecological-examination template
Eliminates NG8107 Angular compiler warnings
Changes
Common-UI/src/registrar/abha-components/abha-consent-form/abha-consent-form.component.css- CSS fixsrc/app/app-modules/nurse-doctor/examination/cancer-examination/gynecological-examination/gynecological-examination.component.html- Template fixesRelated pr
PSMRI/Common-UI#45 - since it requires changes common ui code too