Skip to content

🪲 [Fix]: Update login prompts to use dynamic hostnames for GitHub login processes #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024
Merged

🪲 [Fix]: Update login prompts to use dynamic hostnames for GitHub login processes #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/functions/private/Auth/DeviceFlow/Invoke-GitHubDeviceFlowLogin.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
Write-Host '! ' -ForegroundColor DarkYellow -NoNewline
Write-Host "We added the code to your clipboard: [$userCode]"
$userCode | Set-Clipboard
Read-Host 'Press Enter to open github.com in your browser...'
Read-Host "Press Enter to open $HostName in your browser..."
Start-Process $verificationUri

$tokenResponse = Wait-GitHubAccessToken -DeviceCode $deviceCode -ClientID $ClientID -Interval $interval -HostName $HostName
Expand Down
4 changes: 2 additions & 2 deletions src/functions/public/Auth/Connect-GitHubAccount.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@
Write-Verbose 'Logging in using personal access token...'
Reset-GitHubConfig -Scope 'Auth'
Write-Host '! ' -ForegroundColor DarkYellow -NoNewline
Start-Process 'https://github.com/settings/tokens'
Start-Process "https://$HostName/settings/tokens"
$accessTokenValue = Read-Host -Prompt 'Enter your personal access token' -AsSecureString
$accessTokenType = (ConvertFrom-SecureString $accessTokenValue -AsPlainText) -replace '_.*$', '_*'
if ($accessTokenType -notmatch '^ghp_|^github_pat_') {
Expand All @@ -229,7 +229,7 @@
break
}
'App' {
Write-Verbose 'Logging in using a GitHub App...'
Write-Verbose 'Logging in as a GitHub App...'
Reset-GitHubConfig -Scope 'Auth'
$jwt = Get-GitHubAppJWT -ClientID $ClientID -PrivateKey $PrivateKey
$settings = @{
Expand Down