Skip to content

🩹 [Patch]: Support Token as a SecureString on Connect-GitHubAccount #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MariusStorhaug merged 1 commit into from
Nov 10, 2024
Merged

🩹 [Patch]: Support Token as a SecureString on Connect-GitHubAccount #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/functions/public/Auth/Connect-GitHubAccount.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,15 @@
)]
[switch] $UseAccessToken,

# An access token to use for authentication.
# An access token to use for authentication. Can be both a string or a SecureString.
# Supports both personal access tokens (PAT) and GitHub App installation access tokens (IAT).
# Example: 'ghp_1234567890abcdef'
# Example: 'ghs_1234567890abcdef'
[Parameter(
Mandatory,
ParameterSetName = 'Token'
)]
[string] $Token,
[object] $Token,

# The client ID for the GitHub App to use for authentication.
[Parameter(ParameterSetName = 'UAT')]
Expand Down Expand Up @@ -133,6 +133,10 @@
[switch] $Silent
)
try {
if ($Token -is [System.Security.SecureString]) {
$Token = ConvertFrom-SecureString $Token -AsPlainText
}

$HostName = $HostName -replace '^https?://'
$ApiBaseUri = "https://api.$HostName"
$authType = $PSCmdlet.ParameterSetName
Expand Down