🚀 [Feature]: Add support to run ConvertFrom-SodiumSealedBox without a public key#30
Merged
Marius Storhaug (MariusStorhaug) merged 9 commits intomainfrom Apr 18, 2025
Merged
Conversation
…tFrom-SodiumSealedBox` to improve clarity and add new test cases for decryption without public key
…d add `crypto_scalarmult_base` extern declaration
…from private key if not provided and adjust parameter attributes for clarity
…erivation from private key and error handling for invalid keys
… `Get-SodiumPublicKey`
…t` for base64 decoding and improve error handling for key validation; enhance `Get-SodiumPublicKey` with base64 output option and refactor for clarity.
…ntation and return raw byte array instead of UTF8 string when base64 option is not specified.
…ey as a byte array; update `ConvertFrom-SodiumSealedBox` to utilize new byte array option for public key retrieval.
…utput changes; modify example outputs for clarity and accuracy regarding byte array return.
Marius Storhaug (MariusStorhaug)
changed the title
ConvertFrom-SodiumSealedBox without a public keyConvertFrom-SodiumSealedBox without a public key
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR introduces support for running ConvertFrom-SodiumSealedBox without a public key by enabling the derivation of the public key from the private key. Key changes include:
- Renaming parameters in cryptographic functions (pk/sk → publicKey/privateKey) for improved clarity and consistency.
- Adding a new function, crypto_scalarmult_base, to derive Curve25519 public keys from private keys.
- Updating tests to validate decryption behavior when the public key is omitted.
Files not reviewed (3)
- src/functions/public/ConvertFrom-SodiumSealedBox.ps1: Language not supported
- src/functions/public/Get-SodiumPublicKey.ps1: Language not supported
- tests/Sodium.Tests.ps1: Language not supported
Marius Storhaug (MariusStorhaug)
merged commit ffe7f9c
into
main
51 of 56 checks passed
|
Module Sodium - 2.2.0 published to the PowerShell Gallery. |
|
GitHub release for Sodium v2.2.0 has been created. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new function to derive public keys from private keys, making the public key parameter optional during decryption.
Updates to cryptographic functionality:
Sodium.cs:Sodiumclass to use descriptive names (publicKeyandprivateKey) for better readability and consistency.Sodium.cs:crypto_scalarmult_base, a function for deriving Curve25519 public keys from private keys.Enhancements to decryption usability
Get-SodiumPublicKeyfunction:crypto_scalarmult_basemethod, supporting both base64 and byte array outputs.ConvertFrom-SodiumSealedBox.ps1:PublicKeyparameter optional. If not provided, the public key is derived from the private key using the newGet-SodiumPublicKeyfunction.Improvements to tests:
Sodium.Tests.ps1:Get-SodiumPublicKeyfunction, including validation of derived public keys and error handling for invalid private keys.$encryptedMessage) and streamlined error handling assertions.Type of change
Checklist