Skip to content

🪲 [Fix]: Remove unnecessary LogGroup wrappers in tests #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

🪲 [Fix]: Remove unnecessary LogGroup wrappers in tests #100

merged 1 commit into from
Apr 25, 2025

Conversation

@MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Apr 25, 2025 •
edited
Loading

Description

This pull request simplifies the PSModule.Tests.ps1 script by removing unnecessary logging groups within the test cases which would autoload GitHub and its dependencies, breaking on tests for its dependencies (Sodium, Uri, CaseStyle, etc.).

Simplification of test cases:

  • Removed LogGroup blocks from the Module Manifest exists and Module Manifest is valid tests.

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@MariusStorhaug MariusStorhaug self-assigned this Apr 25, 2025
Copilot AI review requested due to automatic review settings April 25, 2025 13:57
@MariusStorhaug MariusStorhaug requested a review from a team as a code owner April 25, 2025 13:57
Copilot AI reviewed Apr 25, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • scripts/tests/Module/PSModule/PSModule.Tests.ps1: Language not supported

@MariusStorhaug MariusStorhaug merged commit c568915 into main Apr 25, 2025
21 checks passed
@MariusStorhaug MariusStorhaug deleted the fix branch April 25, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@MariusStorhaug MariusStorhaug

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MariusStorhaug