Merged
Conversation
Closed
tomassurin
reviewed
Mar 26, 2026
| SERVER_REQUEST_TIMEOUT: {{ mul 1000 .Values.config.requestTimeoutSeconds | quote }} | ||
| PSPDFKIT_WORKER_TIMEOUT: {{ mul 1000 .Values.config.workerTimeoutSeconds | quote }} | ||
| PSPDFKITD_READ_TIMEOUT: {{ mul 1000 .Values.config.daemonReadTimeoutSeconds | quote }} | ||
| PSPDFKITD_WRITE_TIMEOUT: {{ mul 1000 .Values.config.daemonWriteTimeoutSeconds | quote }} |
Contributor
There was a problem hiding this comment.
We changed naming convention PSPDFKIT vs PSPDFKITD ?
Contributor
Author
There was a problem hiding this comment.
No, we did not. But in configurable options, it's in the daemon section and while it's a subtle difference, it also distinguishes from other timeouts like worker timeout.
tomassurin
reviewed
Mar 26, 2026
| ### Changed | ||
|
|
||
| * [Document Engine 1.15.0](https://www.nutrient.io/guides/document-engine/release-notes/changelog/#1.15.0) | ||
| * New options `daemonReadTimeoutSeconds` and `daemonWriteTimeoutSeconds` are available to control the worker daemon socket timeouts |
Contributor
There was a problem hiding this comment.
Daemon? What if we have more daemons in the system?
Contributor
Author
There was a problem hiding this comment.
Agree, however we have things like workerTimeoutSeconds where we can apply same logic? For Maestro, Vision, ... we should be more consistent.
tomassurin
approved these changes
Mar 26, 2026
Contributor
tomassurin
left a comment
tomassurin
left a comment
There was a problem hiding this comment.
Nitpicks about naming. Keep whatever you like though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[1] #130