Use the uuid property to remove an annotation #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickwinder
approved these changes
Jan 7, 2019
Contributor
nickwinder
left a comment
nickwinder
left a comment
There was a problem hiding this comment.
Windows does not have a remove Annotation yet. Instant features are handled in the SDK so no handling is needed in react-native wrapper.
Co-Authored-By: radazzouz <radazzouz@users.noreply.github.com>
Co-Authored-By: radazzouz <radazzouz@users.noreply.github.com>
irgendeinich
approved these changes
Jan 15, 2019
Contributor
irgendeinich
left a comment
irgendeinich
left a comment
There was a problem hiding this comment.
LGTM 👍
Might make sense to also do it this way on Android, though we would need to expose the UUID first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This is an internal change. It does not impact the React Native JavaScript API. Internally, we are now using the annotation uuid property to remove existing annotation instead of the annotation name property.
Acceptance Criteria