Update to PSPDFKit 3.3.0 #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
Contributor
|
LGTM 👍 |
radazzouz
approved these changes
Jul 26, 2017
Contributor
|
We could also bump the version to 1.3.1 (see #19) and tag as a new release. |
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
Contributor
|
Does the iOS part still work after the |
Contributor
|
I stand by my initial approval! 👍 |
| { | ||
| "name": "Catalog", | ||
| "version": "1.1.0", | ||
| "version": "1.2.0", |
Contributor
There was a problem hiding this comment.
Should we keep the Catalog version in sync with the package version?
Contributor
Author
There was a problem hiding this comment.
That would be ideally a good idea but highly impracticable. Consider the case when the Catalog needs to be upgraded and the package does not.
I would bump the corresponding version only when a change takes places, but we can discuss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #20
Update to PSPDFKit 3.3.0