Implement getAllAnnotations()
#264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Retested and the Android implementation does not impact iOS. |
nickwinder
approved these changes
Aug 7, 2019
Contributor
nickwinder
left a comment
nickwinder
left a comment
There was a problem hiding this comment.
Does not touch Windows . 👍
irgendeinich
approved these changes
Aug 8, 2019
Contributor
irgendeinich
left a comment
irgendeinich
left a comment
There was a problem hiding this comment.
LGTM, pinging @simoarpe to review the Java part.
simoarpe
approved these changes
Aug 8, 2019
Contributor
simoarpe
left a comment
simoarpe
left a comment
There was a problem hiding this comment.
👍 Android part looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The iOS and Android implementation for #167
Acceptance Criteria
getAllAnnotations()on iOS.getAllAnnotations()on Android.iosandandroidtags from #167 and leave the issue opened for UWP.package.json,package-lock.json, andsamples/Catalog/package.json(see example commit: 1bf805f).