Android module enhancements #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
irgendeinich
suggested changes
Mar 22, 2018
Contributor
irgendeinich
left a comment
irgendeinich
left a comment
There was a problem hiding this comment.
Not passing in the Application causes setPageIndex to no longer work.
Also while we're at it we could bump the PSPDFKit version as well.
Contributor
There was a problem hiding this comment.
This sadly doesn't work since getCurrentActivity returns null when starting up the app. So our setPageIndex method won't work anymore.
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
simoarpe
force-pushed
the
simone/issue/fix-android-project
branch
from
4d7dc46 to
468f218
Compare
Signed-off-by: Simone Arpe <simon.arpe@gmail.com>
irgendeinich
approved these changes
Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
ReactFragmentActivityas it's officially provided by Facebook now, and revertsPSPDFKitPackageto a no-argument constructor. This is required to supportreact-native link <module>command or we have to switch back to manual linking, something that is highly unrecommended considering we have already 12 steps for integrating thereact-native-pspdfkitmodule.