Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Controller diagram #400

Merged
merged 2 commits into from
Dec 30, 2017
Merged

Controller diagram #400

merged 2 commits into from
Dec 30, 2017

Conversation

hamishwillee
Copy link
Collaborator

Add position controller diagram from PX4/PX4-Autopilot#8316. You can see this rendered here.

@Stifael @bresch This is primarily for discussion. We might for example decide that:

  • We want individual documents for each diagram
  • We want a document for each controller, which happens to include the diagram.

Depends on what else is worth saying about controllers - e.g. What would you put in slides if you had to present on this in a webinar say :-) Links to source code etc?

@bresch there is also a placeholder doc for the notation. If you provide me the source text, I can add it (up to you).

@hamishwillee
Copy link
Collaborator Author

@bresch You may be on holiday, but if not, can you send me your notation doc? I'd rather get this merged and then iterate than wait on perfection.

@Stifael Any thoughts on discussion in #400 (comment) . Specifically, what else would you like said here or is it OK? Is there a lot more that we might say in a position controller document such that this would just be part of that document?

@bresch
Copy link
Member

bresch commented Dec 28, 2017

can you send me your notation doc?

The glossary? Here is its repo

@LorenzMeier LorenzMeier merged commit 2b9befd into master Dec 30, 2017
@LorenzMeier LorenzMeier deleted the controller_diagram branch December 30, 2017 14:03
@hamishwillee hamishwillee changed the title Controller diagram [Under Construction] Controller diagram Jan 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants