Skip to content

minor adjustments#17

Merged
PabloZaiden merged 1 commit into
mainfrom
filters-fullscreen
May 4, 2026
Merged

minor adjustments#17
PabloZaiden merged 1 commit into
mainfrom
filters-fullscreen

Conversation

@PabloZaiden
Copy link
Copy Markdown
Owner

This pull request refactors the filter and control layout in the graph view and standardizes UI element heights for a more consistent appearance. The main changes include separating filters and controls in the GraphMap component, updating their positioning, and unifying the height and padding of buttons and inputs across the app.

GraphMap layout and filter/control separation:

  • Refactored the GraphMap component to accept separate filters and controls props, rendering them in distinct positions: filters on the left and controls on the right of the graph viewport. This improves clarity and organization of UI elements. [1] [2]
  • Updated the App component to use the new filters prop, moving filter UI out of the main panel and into the new location in GraphMap. [1] [2] [3]

Fullscreen and viewport improvements:

  • Added an onFullscreenChange prop to GraphMap to allow parent components to react to fullscreen state changes, and improved the logic for detecting fullscreen mode. [1] [2] [3]
  • Removed the border from the graph viewport shell for a cleaner look in both normal and fullscreen modes.

UI consistency and styling:

  • Standardized the height and vertical alignment of buttons, inputs, and filter menus to 38px, and adjusted padding for a more uniform and polished appearance throughout the app. [1] [2] [3] [4]

Minor cleanup:

  • Removed the unused Panel component import from App.tsx.

Copilot AI review requested due to automatic review settings May 4, 2026 15:48
@PabloZaiden PabloZaiden merged commit f38b359 into main May 4, 2026
2 checks passed
@PabloZaiden PabloZaiden deleted the filters-fullscreen branch May 4, 2026 15:49
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the graph viewport UI so filters and controls are rendered in separate overlay positions (filters left, controls right) and introduces some global styling tweaks to standardize control sizing and improve fullscreen behavior.

Changes:

  • Updated GraphMap to accept separate filters and controls props, and added an optional onFullscreenChange callback.
  • Moved the graph search + type filters UI out of the main panel area and into the GraphMap overlay via the new filters prop.
  • Standardized base button/input styling to target a consistent 38px control height.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/index.css Updates base styling for buttons/inputs and adjusts filter menu summary sizing.
src/app/GraphMap.tsx Adds filters + onFullscreenChange props, updates fullscreen detection, and repositions overlay UI.
src/App.tsx Removes Panel usage around the graph and supplies the new filters prop to GraphMap.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/index.css
Comment on lines 36 to 40
input,
select,
textarea {
@apply w-full rounded-lg border border-zinc-700 bg-zinc-950 px-3 py-2 text-sm text-zinc-100 placeholder:text-zinc-500 outline-none focus:border-stone-400;
@apply h-[38px] w-full rounded-lg border border-zinc-700 bg-zinc-950 px-3 py-2 text-sm leading-5 text-zinc-100 placeholder:text-zinc-500 outline-none focus:border-stone-400;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants