minor adjustments#17
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the graph viewport UI so filters and controls are rendered in separate overlay positions (filters left, controls right) and introduces some global styling tweaks to standardize control sizing and improve fullscreen behavior.
Changes:
- Updated
GraphMapto accept separatefiltersandcontrolsprops, and added an optionalonFullscreenChangecallback. - Moved the graph search + type filters UI out of the main panel area and into the
GraphMapoverlay via the newfiltersprop. - Standardized base button/input styling to target a consistent 38px control height.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/index.css | Updates base styling for buttons/inputs and adjusts filter menu summary sizing. |
| src/app/GraphMap.tsx | Adds filters + onFullscreenChange props, updates fullscreen detection, and repositions overlay UI. |
| src/App.tsx | Removes Panel usage around the graph and supplies the new filters prop to GraphMap. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
36
to
40
| input, | ||
| select, | ||
| textarea { | ||
| @apply w-full rounded-lg border border-zinc-700 bg-zinc-950 px-3 py-2 text-sm text-zinc-100 placeholder:text-zinc-500 outline-none focus:border-stone-400; | ||
| @apply h-[38px] w-full rounded-lg border border-zinc-700 bg-zinc-950 px-3 py-2 text-sm leading-5 text-zinc-100 placeholder:text-zinc-500 outline-none focus:border-stone-400; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the filter and control layout in the graph view and standardizes UI element heights for a more consistent appearance. The main changes include separating filters and controls in the
GraphMapcomponent, updating their positioning, and unifying the height and padding of buttons and inputs across the app.GraphMap layout and filter/control separation:
GraphMapcomponent to accept separatefiltersandcontrolsprops, rendering them in distinct positions: filters on the left and controls on the right of the graph viewport. This improves clarity and organization of UI elements. [1] [2]Appcomponent to use the newfiltersprop, moving filter UI out of the main panel and into the new location inGraphMap. [1] [2] [3]Fullscreen and viewport improvements:
onFullscreenChangeprop toGraphMapto allow parent components to react to fullscreen state changes, and improved the logic for detecting fullscreen mode. [1] [2] [3]UI consistency and styling:
Minor cleanup:
Panelcomponent import fromApp.tsx.