updated: model_kwargs handling for evaluation model#1133
Merged
chakravarthik27 merged 2 commits intorelease/2.5.0from Oct 30, 2024
Merged
Conversation
chakravarthik27
changed the title
chakravarthik27
changed the title
Prikshit7766
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
load_modelmethod in thelangtest/modelhandler/llm_modelhandler.pyfile. The changes mainly involve cleaning up commented-out code and adding a new handling case for mapping a path dictionary to a model object.Code cleanup and new handling case:
ollamahub. (langtest/modelhandler/llm_modelhandler.py, langtest/modelhandler/llm_modelhandler.pyL113-L117)langtest/modelhandler/llm_modelhandler.py, langtest/modelhandler/llm_modelhandler.pyR135-R137)