Skip to content

feature: add poetry#588

Merged
ArshaanNazir merged 9 commits intorelease/1.1.0from
feature/add-poetry
Jul 4, 2023
Merged

feature: add poetry#588
ArshaanNazir merged 9 commits intorelease/1.1.0from
feature/add-poetry

Conversation

@JulesBelveze
Copy link
Copy Markdown
Contributor

@JulesBelveze JulesBelveze commented Jul 4, 2023 •
edited
Loading

This PR aims at using poetry as a dependency manager

Checklist:

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

@JulesBelveze JulesBelveze added the 🛠️ Maintenance Flagged under maintenance label Jul 4, 2023
@JulesBelveze JulesBelveze self-assigned this Jul 4, 2023
@JulesBelveze JulesBelveze marked this pull request as draft July 4, 2023 10:44
@JulesBelveze JulesBelveze changed the title Draft: feature: add poetry feature: add poetry Jul 4, 2023
@JulesBelveze JulesBelveze marked this pull request as ready for review July 4, 2023 15:47
@JulesBelveze
Copy link
Copy Markdown
Contributor Author

JulesBelveze commented Jul 4, 2023

@ArshaanNazir @chakravarthik27 this will be tackled in a separate PR if we agree but how do you feel with moving the package build and push to poetry as well and have it part of the CI?

@JulesBelveze JulesBelveze linked an issue Jul 4, 2023 that may be closed by this pull request
Add poetry to manage dependencies, etc. #557
Closed
@chakravarthik27
Copy link
Copy Markdown
Collaborator

chakravarthik27 commented Jul 4, 2023

have it part of the CI?

It's looking good to use poetry.

@ArshaanNazir ArshaanNazir changed the base branch from main to release/1.0.0 July 4, 2023 16:39
@ArshaanNazir ArshaanNazir merged commit 0f527ed into release/1.1.0 Jul 4, 2023
@JulesBelveze JulesBelveze deleted the feature/add-poetry branch July 5, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chakravarthik27 chakravarthik27 Awaiting requested review from chakravarthik27

1 more reviewer

@ArshaanNazir ArshaanNazir ArshaanNazir approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JulesBelveze JulesBelveze

Labels

🛠️ Maintenance Flagged under maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add poetry to manage dependencies, etc.

3 participants

@JulesBelveze @chakravarthik27 @ArshaanNazir