Skip to content

feature/ Robustness Tests -> Adjective synonym/antonym Swap#611

Merged
JulesBelveze merged 16 commits intorelease/1.1.0from
add-more-robustness-tests-adjectives-age
Jul 14, 2023
Merged

feature/ Robustness Tests -> Adjective synonym/antonym Swap#611
JulesBelveze merged 16 commits intorelease/1.1.0from
add-more-robustness-tests-adjectives-age

Conversation

@RakshitKhajuria
Copy link
Copy Markdown
Contributor

@RakshitKhajuria RakshitKhajuria commented Jul 11, 2023

This PR aims at adding new robustness tests ⭐


Checklist:

  • Adjective Synonym swap

    • Adjective Synonym swap : Data Dictionary scrapped from this website -> https://www.thesaurus.com/
  • Adjective Antonym swap

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

@RakshitKhajuria RakshitKhajuria added ⭐ Feature Indicates new feature requests v2.1.0 Issue or request to be done in v2.1.0 release labels Jul 11, 2023
@RakshitKhajuria RakshitKhajuria marked this pull request as draft July 11, 2023 17:25
@RakshitKhajuria RakshitKhajuria linked an issue Jul 12, 2023 that may be closed by this pull request
@JulesBelveze
Copy link
Copy Markdown
Contributor

@RakshitKhajuria let's split this PR into two: one for "adjective swap" and one for "age" and let's merge this one. What do you think?

@RakshitKhajuria
Copy link
Copy Markdown
Contributor Author

@RakshitKhajuria let's split this PR into two: one for "adjective swap" and one for "age" and let's merge this one. What do you think?

Sure, that will be fine !

@RakshitKhajuria RakshitKhajuria changed the title feature/ Robustness Tests -> AdjectiveSwap and Age feature/ Robustness Tests -> AdjectiveSwap Jul 14, 2023
@RakshitKhajuria RakshitKhajuria marked this pull request as ready for review July 14, 2023 07:43
@RakshitKhajuria RakshitKhajuria changed the title feature/ Robustness Tests -> AdjectiveSwap feature/ Robustness Tests -> Adjective synonym/antonym Swap Jul 14, 2023
Copy link
Copy Markdown
Contributor

@JulesBelveze JulesBelveze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff!

@JulesBelveze JulesBelveze merged commit c3457c0 into release/1.1.0 Jul 14, 2023
@JulesBelveze JulesBelveze deleted the add-more-robustness-tests-adjectives-age branch July 14, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⭐ Feature Indicates new feature requests v2.1.0 Issue or request to be done in v2.1.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more robustness tests (adjectives, age)

3 participants