Fix/religion bias space issue#966
Merged
ArshaanNazir merged 2 commits intorelease/2.0.0from Jan 28, 2024
Merged
Conversation
ArshaanNazir
approved these changes
Jan 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem in religion bias
so in transformed text it is concatenating
byMohitRanjanabut it is wrong and there should be spaceThe issue is due to leading and trailing spaces present in some names within the
religion_wise_namesdictionary located in constants.py. I have now stripped leading and trailing spaces from all names in the dictionary.➤ Fixes # (issue)
Type of change
Please delete options that are not relevant.
Usage
Checklist:
pydanticfor typing when/where necessary.