Skip to content

Fix/religion bias space issue#966

Merged
ArshaanNazir merged 2 commits intorelease/2.0.0from
fix/religion-bias-space-issue
Jan 28, 2024
Merged

Fix/religion bias space issue#966
ArshaanNazir merged 2 commits intorelease/2.0.0from
fix/religion-bias-space-issue

Conversation

@Prikshit7766
Copy link
Contributor

@Prikshit7766 Prikshit7766 commented Jan 27, 2024

Description

Problem in religion bias

  • text= Nader Jokhadar headed a cross from the right by Ammar Awad into the top right corner of Kenichi Shimokawa 's goal .
  • transformed sentence = Nader Jokhadar headed a cross from the right byMohitRanjana into the top right corner of Kenichi Shimokawa 's goal .

so in transformed text it is concatenating byMohitRanjana but it is wrong and there should be space

1
2
3
4
5

The issue is due to leading and trailing spaces present in some names within the religion_wise_names dictionary located in constants.py. I have now stripped leading and trailing spaces from all names in the dictionary.


➤ Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Usage

Checklist:

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

@ArshaanNazir ArshaanNazir merged commit c4bbfa4 into release/2.0.0 Jan 28, 2024
@ArshaanNazir ArshaanNazir deleted the fix/religion-bias-space-issue branch February 13, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants