BUGFIX: Ternary with nested variable access in condition #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nope should work out of the box ^^ |
I have the feeling it's the right way. It just fell like this into place. Cant 100% explain why but after debugging it i think it is right.
mhsdesign
changed the title
grebaldi
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Hi @mhsdesign,
thanks for fixing this!
I saw that php-stan was complaining about the missing return type of ternaryOperationWithVariablesInConditionExamples. So I took the liberty of adding it. Along the way I also added two more examples to the data provider to stress-test the solution. Works superbly! 👍
|
|
||
| /** | ||
| * @dataProvider ternaryOperationExamples | ||
| * @dataProvider ternaryOperationWithVariablesInConditionExamples |
There was a problem hiding this comment.
TIL :) I did not know this was possible :D
grebaldi
deleted the
bugfix/ternary-with-nested-variable-access-in-condition
branch
|
Yeah... I ran the wrong tests... I'm an idiot 😅 Will fix in main soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously:
true === someStruct.foo ? "a" : "foo"is not correctly transpiled. (Its valid ecmascript see the ast that should be build: https://astexplorer.net)i looked now a long time at this code, and still dont know if this is the right solution or if we need to fix the precedence of something ...