BUGFIX: Ensure compatibility with PHP 8.1 and Neos 8#28
Merged
Conversation
This required an adjustent to the Enum Generator because of a deprecation message: > PHP Deprecated: Optional parameter $now declared before required parameter $fileWriter is implicitly treated as a required parameter in EnumGenerator.php on line 23
This required an adjustment to the `PresentationObjectComponentImplementationTest`, because of a leaking implementation detail of `AbstractArrayFusionObject`.
This was
linked to
issues
Dec 20, 2022
Closed
Closed
nezaniel
approved these changes
Jan 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #26, #27
Description's in the title :D
I tested with PHP 8.1 and Neos 8.2 and found no issues.
Unit tests were mad at me, because the implementation of
AbstractArrayFusionObject::sortNestedFusionKeyshas changed in a way that confusedProphecy\Prophet(leaky implementation detail). I therefore do not expect that the changed test will run with anything below Neos 8, but for now, our automated tests would fetch Neos 8 anyway.