Skip to content

fix: Instantiate null logger once#145

Merged
davidgrayston-paddle merged 1 commit intomainfrom
fix/instantiate-null-logger-once
Apr 21, 2026
Merged

fix: Instantiate null logger once#145
davidgrayston-paddle merged 1 commit intomainfrom
fix/instantiate-null-logger-once

Conversation

@davidgrayston-paddle
Copy link
Copy Markdown
Contributor

@davidgrayston-paddle davidgrayston-paddle commented Apr 20, 2026

Fixed

  • Fixed a handler leak in Client.null_logger() where a new NullHandler was attached to the shared "null_logger" logger on every Client instantiation. The NullHandler is now only attached when the logger has no handlers configured.

vifer
vifer approved these changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@vifer vifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@davidgrayston-paddle davidgrayston-paddle marked this pull request as ready for review April 20, 2026 23:49
@davidgrayston-paddle davidgrayston-paddle requested a review from a team as a code owner April 20, 2026 23:49
@davidgrayston-paddle davidgrayston-paddle self-assigned this Apr 20, 2026
@davidgrayston-paddle davidgrayston-paddle merged commit 75b2f44 into main Apr 21, 2026
6 of 7 checks passed
@davidgrayston-paddle davidgrayston-paddle deleted the fix/instantiate-null-logger-once branch April 21, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vifer vifer vifer approved these changes

Assignees

@davidgrayston-paddle davidgrayston-paddle

Labels

release:patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidgrayston-paddle @vifer