[xpu] add ep custom ops #3911
Merged
[xpu] add ep custom ops #3911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhupengyang
force-pushed
the
custom_ops
branch
3 times, most recently
from
48c26b4 to
61ba786
Compare
zhupengyang
changed the title
zhupengyang
force-pushed
the
custom_ops
branch
2 times, most recently
from
1cd3111 to
e754168
Compare
zhupengyang
changed the title
Jiang-Jia-Jun
previously approved these changes
Sep 8, 2025
hong19860320
reviewed
Sep 8, 2025
custom_ops/setup_ops.py
Outdated
| ) | ||
| elif paddle.is_compiled_with_xpu(): | ||
| assert False, "In XPU, we should use setup_ops.py in xpu_ops/src, not this." | ||
| assert False, "In XPU, we should use setup_ops.py in xpu_ops/, not this." |
Collaborator
There was a problem hiding this comment.
For XPU, please use setup_ops.py in the xpu_ops directory to compile custom ops.
zhupengyang
dismissed stale reviews from Jiang-Jia-Jun and hong19860320
via
01cfebf
zhupengyang
force-pushed
the
custom_ops
branch
from
e754168 to
01cfebf
Compare
XiaoguangHu01
approved these changes
Sep 10, 2025
XiaoguangHu01
left a comment
XiaoguangHu01
left a comment
There was a problem hiding this comment.
GPU版本算子接口有差异，和业界实现的接口有差异，算子的定义应该是设备无关的。可以先合入，后续需要改进。
| return {x_dtype, x_dtype}; | ||
| } | ||
|
|
||
| PD_BUILD_STATIC_OP(fused_rms_norm_xpu) |
There was a problem hiding this comment.
为什么需要给xpu单独写一个fused_rms_norm算子呢？和gpu版本的算子有什么区别？
kernel实现可以是硬件相关的，但是算子定义应该是硬件无关的。
DDDivano
approved these changes
Sep 10, 2025
heavengate
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.