Skip to content

[XPU] bug fix block attn in mix mtp#5384

Merged
cmcamdy merged 1 commit intoPaddlePaddle:developfrom
cmcamdy:mtp_xpu_insert_v1
Dec 5, 2025
Merged

[XPU] bug fix block attn in mix mtp#5384
cmcamdy merged 1 commit intoPaddlePaddle:developfrom
cmcamdy:mtp_xpu_insert_v1

Conversation

@cmcamdy
Copy link
Collaborator

@cmcamdy cmcamdy commented Dec 5, 2025

Motivation

测试开了MTP的benchmark时发现高batch下模型输出出现乱码,定位原因发现是split_rope_cache_kv_encoder没有在集中式场景下对qkv做偏移。
image

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

Modifications

考虑集中式encoder decoder同时存在的情况,修复block attn
image

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@2e16808). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5384   +/-   ##
==========================================
  Coverage           ?   59.26%           
==========================================
  Files              ?      325           
  Lines              ?    40216           
  Branches           ?     6087           
==========================================
  Hits               ?    23832           
  Misses             ?    14550           
  Partials           ?     1834           
Flag Coverage Δ
GPU 59.26% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmcamdy cmcamdy merged commit 86b6430 into PaddlePaddle:develop Dec 5, 2025
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants