Skip to content

Conversation

@kesmeey
Copy link
Collaborator

@kesmeey kesmeey commented Jan 30, 2026

Motivation

功能模块 fastdeploy/engine/common_engine.py 单测补充

Modifications

image develop分支,覆盖率33%,miss行数766(74, 160, 167-168, 206->210, 224-227, 238, 376, 378->411, 388->397, 397->411, 425-514, 523-566, 572-573, 579, 586-632, 638-708, 715-781, 787-1049, 1053, 1056-1058, 1079-1080, 1088, 1098, 1103, 1106-1114, 1119-1166, 1172-1174, 1177-1186, 1209-1232, 1247-1289, 1300-1308, 1320-1322, 1335-1341, 1349-1379, 1382-1385, 1388-1402, 1405-1416, 1422-1490, 1501-1523, 1526-1557, 1561-1606, 1609-1619, 1636, 1639-1649, 1658-1692, 1709->1718, 1718->1732, 1732->1744, 1737->1744, 1802->1813, 1835->exit, 1881-1887, 1890, 2023, 2027->exit, 2036->2041, 2055, 2067->exit, 2082, 2112, 2120-2135, 2145->2147, 2151, 2158->2160, 2164, 2169-2170) image

当前pr,覆盖率83%,miss行数170

完成覆盖行数 766-170=596

Usage or Command

No need

Accuracy Tests

No need

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Jan 30, 2026

Thanks for your contribution!

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@d60daca). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #6292   +/-   ##
==========================================
  Coverage           ?   69.57%           
==========================================
  Files              ?      391           
  Lines              ?    52509           
  Branches           ?     8195           
==========================================
  Hits               ?    36535           
  Misses             ?    13293           
  Partials           ?     2681           
Flag Coverage Δ
GPU 69.57% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

except Exception:
pass

def test_force_coverage_for_common_engine(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样不行,需要真正运行到才可以

User and others added 2 commits February 5, 2026 14:24
Expand common engine tests and helpers while
aligning setup and cleanup behavior.

Co-authored-by: Cursor <cursoragent@cursor.com>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kesmeey
❌ User


User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants