-
Notifications
You must be signed in to change notification settings - Fork 701
[CI] 【Hackathon 10th Spring No.20】功能模块 fastdeploy/engine/common_engine.py 单测补充 #6292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Thanks for your contribution! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6292 +/- ##
==========================================
Coverage ? 69.57%
==========================================
Files ? 391
Lines ? 52509
Branches ? 8195
==========================================
Hits ? 36535
Misses ? 13293
Partials ? 2681
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tests/engine/test_common_engine.py
Outdated
| except Exception: | ||
| pass | ||
|
|
||
| def test_force_coverage_for_common_engine(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这样不行,需要真正运行到才可以
Expand common engine tests and helpers while aligning setup and cleanup behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
|
User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Co-authored-by: Cursor <cursoragent@cursor.com>
Motivation
功能模块 fastdeploy/engine/common_engine.py 单测补充
Modifications
当前pr,覆盖率83%,miss行数170
完成覆盖行数 766-170=596
Usage or Command
No need
Accuracy Tests
No need
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.