Skip to content

[Bug Fix] Fix MM mtp incorrect rope emb#6581

Merged
EmmonsCurse merged 4 commits intoPaddlePaddle:developfrom
ming1753:mtp
Mar 3, 2026
Merged

[Bug Fix] Fix MM mtp incorrect rope emb#6581
EmmonsCurse merged 4 commits intoPaddlePaddle:developfrom
ming1753:mtp

Conversation

@ming1753
Copy link
Collaborator

Motivation

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

Modifications

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Feb 28, 2026

Thanks for your contribution!

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2026

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@3cc0941). Learn more about missing BASE report.

Files with missing lines Patch % Lines
fastdeploy/worker/input_batch.py 10.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #6581   +/-   ##
==========================================
  Coverage           ?   71.60%           
==========================================
  Files              ?      394           
  Lines              ?    53951           
  Branches           ?     8466           
==========================================
  Hits               ?    38633           
  Misses             ?    12529           
  Partials           ?     2789           
Flag Coverage Δ
GPU 71.60% <10.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@EmmonsCurse EmmonsCurse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ Skip coverage check as it mainly relies on eb5 tests.

@EmmonsCurse EmmonsCurse merged commit c5eb6b6 into PaddlePaddle:develop Mar 3, 2026
19 of 24 checks passed
EmmonsCurse pushed a commit that referenced this pull request Mar 3, 2026
* [Bug Fix] Fix MM mtp incorrect rope emb

* fix bug
@ming1753 ming1753 deleted the mtp branch March 3, 2026 13:05
ming1753 added a commit that referenced this pull request Mar 3, 2026
ming1753 added a commit that referenced this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants