[Optimization] merge_allreduce#7039
Merged
ckl117 merged 3 commits intoPaddlePaddle:developfrom Apr 2, 2026
Merged
Conversation
|
Thanks for your contribution! |
| # In all other modes (EP, EP+attn-TP, no parallelism) each branch handles | ||
| # its own reduction internally (reduce_results default=True), so we must | ||
| # NOT add an extra all-reduce here. | ||
| self._pure_tp = self.use_tp and not self.use_ep |
Collaborator
There was a problem hiding this comment.
这个变量应该叫 self.merge_ffn_tp 是不是更好点
Contributor
Author
There was a problem hiding this comment.
这个变量应该叫 self.merge_ffn_tp 是不是更好点
是的,更容易理解一些
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7039 +/- ##
==========================================
Coverage ? 73.73%
==========================================
Files ? 376
Lines ? 52853
Branches ? 8240
==========================================
Hits ? 38969
Misses ? 11177
Partials ? 2707
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
20b48a5 to
6e1b3e9
Compare
ckl117
previously approved these changes
Apr 1, 2026
ckl117
approved these changes
Apr 2, 2026
Copilot AI
pushed a commit
that referenced
this pull request
Apr 17, 2026
Co-authored-by: Jiang-Jia-Jun <163579578+Jiang-Jia-Jun@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
将普通专家和共享专家在计算ffn后各自的allreduce合并为一个allreduce
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.