[BugFix] fix speculative gauge metrics in multi api server#7082
Merged
Jiang-Jia-Jun merged 1 commit intoPaddlePaddle:developfrom Mar 31, 2026
Merged
Conversation
|
Thanks for your contribution! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7082 +/- ##
==========================================
Coverage ? 73.07%
==========================================
Files ? 402
Lines ? 56470
Branches ? 8917
==========================================
Hits ? 41266
Misses ? 12289
Partials ? 2915
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
freeliuzc
approved these changes
Mar 30, 2026
Jiang-Jia-Jun
approved these changes
Mar 31, 2026
Collaborator
|
❌ Cherry-pick failed: Conflicts detected when cherry-picking to |
mattheliu
pushed a commit
to mattheliu/FastDeploy
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes duplicated/incorrect speculative gauge metrics export under
MultiAPIServerin multi-DP scenarios.There are two issues:
MultiAPIServerdid not isolatePROMETHEUS_MULTIPROC_DIRacross DP instances, which could cause metric file collisions between different DP processes.Modifications
Fix the speculative metrics export logic in multiprocess mode:
main_process_metricsIsolate
PROMETHEUS_MULTIPROC_DIRfor each DP instance underMultiAPIServer:Add unit tests for multiprocess gauge export:
pidpidpidUsage or Command
Run unit tests:
Accuracy Tests
N/A. This PR does not change model computation or model outputs. It only fixes metrics export behavior.
Checklist