[Others] replace tool_helpers to fast_dataindex#7353
[Others] replace tool_helpers to fast_dataindex#7353carryyu merged 2 commits intoPaddlePaddle:developfrom
Conversation
|
Thanks for your contribution! |
PaddlePaddle-bot
left a comment
PaddlePaddle-bot
left a comment
There was a problem hiding this comment.
📋 Review 摘要
PR 概述：将依赖包 tool_helpers 替换为 fast_dataindex 以支持 ARM 平台安装
变更范围：4 个 requirements 文件（requirements.txt、requirements_dcu.txt、requirements_iluvatar.txt、requirements_metaxgpu.txt）
影响面 Tag：[Others] [CI]
📝 PR 规范检查
PR 规范检查通过。标题包含 [Others] Tag，描述已填写 Motivation 和 Modifications。
问题
| 级别 | 文件 | 概述 |
|---|---|---|
| 🟡 建议 | requirements.txt |
缺少 fast_dataindex 版本约束 |
| 🟡 建议 | requirements_dcu.txt |
缺少 fast_dataindex 版本约束 |
| 🟡 建议 | requirements_iluvatar.txt |
缺少 fast_dataindex 版本约束 |
| 🟡 建议 | requirements_metaxgpu.txt |
缺少 fast_dataindex 版本约束 |
总体评价
PR 变更简洁明确，目的是支持 ARM 平台安装。由于代码库中未发现直接使用 tool_helpers 或 fast_dataindex，这可能是间接依赖。建议添加版本约束以确保依赖稳定性，并在合并前验证功能正常。
| etcd3 | ||
| httpx | ||
| tool_helpers | ||
| fast_dataindex |
There was a problem hiding this comment.
🟡 建议 添加 fast_dataindex 的版本约束
建议指定版本范围（如 fast_dataindex>=1.0.0），以确保依赖稳定性和可复现性。
同时建议验证 fast_dataindex 与原 tool_helpers 的 API 兼容性，确保间接依赖的功能不受影响。
| etcd3 | ||
| httpx | ||
| tool_helpers | ||
| fast_dataindex |
There was a problem hiding this comment.
🟡 建议 添加 fast_dataindex 的版本约束
建议指定版本范围（如 fast_dataindex>=1.0.0），以确保依赖稳定性和可复现性。
| etcd3 | ||
| httpx | ||
| tool_helpers | ||
| fast_dataindex |
There was a problem hiding this comment.
🟡 建议 添加 fast_dataindex 的版本约束
建议指定版本范围（如 fast_dataindex>=1.0.0），以确保依赖稳定性和可复现性。
| etcd3 | ||
| httpx | ||
| tool_helpers | ||
| fast_dataindex |
There was a problem hiding this comment.
🟡 建议 添加 fast_dataindex 的版本约束
建议指定版本范围（如 fast_dataindex>=1.0.0），以确保依赖稳定性和可复现性。
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7353 +/- ##
==========================================
Coverage ? 74.13%
==========================================
Files ? 383
Lines ? 53588
Branches ? 8405
==========================================
Hits ? 39728
Misses ? 11164
Partials ? 2696
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/re-run all-failed |
4 participants
Motivation
Fastdeploy支持arm安装
Modifications
将tool_helpers使用fast_dataindex，fast_dataindex是tool_helpers的升级改了个名字，且fast_dataindex有arm版本包
Usage or Command
no
Accuracy Tests
no
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.