[CI] Modify 4-card container startup config and move test case#7363
Merged
yuanlehome merged 1 commit intoPaddlePaddle:developfrom Apr 13, 2026
Merged
[CI] Modify 4-card container startup config and move test case#7363yuanlehome merged 1 commit intoPaddlePaddle:developfrom
yuanlehome merged 1 commit intoPaddlePaddle:developfrom
Conversation
|
Thanks for your contribution! |
Collaborator
Author
|
/skip-ci ci_iluvatar |
PaddlePaddle-bot
left a comment
There was a problem hiding this comment.
🤖 AI Code Review |
2026-04-13
📋 Review 摘要
PR 概述:优化 4 卡 CI 容器启动配置,支持 RDMA 环境
变更范围:.github/workflows/_gpu_4cards_case_test.yml、tests/e2e/4cards_cases/
影响面 Tag:[CI]
📝 PR 规范检查
PR 标题和描述均符合规范,Motivation 和 Modifications 章节清晰。
问题
未发现阻塞性问题。
总体评价
本次 PR 合理地添加了 RDMA 设备挂载、必要的 Docker capabilities(SYS_PTRACE、IPC_LOCK)、共享内存配置(64G)和 ulimit 设置,以支持 RDMA 环境下的 4 卡测试。测试文件的导入路径和 GPU 设备分配修正也是正确的。
💡 改进建议(非阻塞性)
虽然不在本次 PR 变更范围内,但注意到 .github/workflows/_gpu_4cards_case_test.yml:158 的 PORTS 数组未包含本次新增的 FD_ROUTER_PORT、FD_CONNECTOR_PORT、FD_RDMA_PORT,可能需要后续补充端口清理逻辑。
yuanlehome
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
RDMA_DEVICES)/dev/infiniband/rdma_cmfor RDMA communication--ulimit memlock=-1:-1to support RDMA memory lockingSYS_PTRACE,IPC_LOCK)--shm-size=64g)CLEAN_CUDA=1)test_ernie_03b_pd_router_v1_rdma_tp2.pyinto4cards_casesdirectory for clearer test groupingUsage or Command
N/A
Accuracy Tests
N/A
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.