Skip to content

[Iluvatar] fix ci error and update readme#7453

Merged
EmmonsCurse merged 1 commit intoPaddlePaddle:developfrom
wuyujiji:yuzhe_dev
Apr 17, 2026
Merged

[Iluvatar] fix ci error and update readme#7453
EmmonsCurse merged 1 commit intoPaddlePaddle:developfrom
wuyujiji:yuzhe_dev

Conversation

@wuyujiji
Copy link
Copy Markdown
Contributor

@wuyujiji wuyujiji commented Apr 17, 2026

Motivation

修复ci报错,更新readme

Modifications

Pass

Usage or Command

Pass

Accuracy Tests

Pass

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link
Copy Markdown

paddle-bot bot commented Apr 17, 2026

Thanks for your contribution!

@paddle-bot paddle-bot bot added the contributor External developers label Apr 17, 2026
PaddlePaddle-bot

This comment was marked as outdated.

@EmmonsCurse
Copy link
Copy Markdown
Collaborator

/skip-ci ci_hpu
/skip-ci build_gpu
/skip-ci build_xpu

@wuyujiji wuyujiji changed the title [Iiluvatar] fix ci error and update readme [Iluvatar] fix ci error and update readme Apr 17, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@91b8bf2). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #7453   +/-   ##
==========================================
  Coverage           ?   74.22%           
==========================================
  Files              ?      398           
  Lines              ?    54947           
  Branches           ?     8609           
==========================================
  Hits               ?    40787           
  Misses             ?    11426           
  Partials           ?     2734           
Flag Coverage Δ
GPU 74.22% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@PaddlePaddle-bot PaddlePaddle-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Code Review | 2026-04-17 13:42 CST

📋 Review 摘要

PR 概述:修复 Iluvatar CI 报错,更新 README 安装文档,对齐 MoE backend 基类接口
变更范围:文档(中英文安装指南)、MoE 层 backend、依赖文件
影响面 TagIluvatar OP Docs

📝 PR 规范检查

PR 描述中 Modifications/Usage/Accuracy Tests 均填写 "Pass",建议补充具体修改内容说明,便于后续追溯。

描述建议(可直接复制):

## Modifications

1. 更新中英文 Iluvatar 安装文档:添加 --extra-index-url、--recursive 参数、安装步骤结构优化
2. 对齐 IluvatarCutlassMoEMethod.apply_tp 签名与基类 MoEMethodBase,新增 fc1_latent_proj/fc2_latent_proj 支持
3. requirements_iluvatar.txt 新增 paddleocr[doc-parser]==3.3.2 依赖

问题

未发现阻塞性问题。

详细分析

1. apply_tp 签名对齐(fuse_moe_cutlass_iluvatar_backend.py)

  • 基类 MoEMethodBase.apply_tp 已定义 fc1_latent_proj / fc2_latent_proj 参数(默认 None
  • GPU cutlass backend、deepgemm backend 等均已实现该签名
  • 本次 Iluvatar backend 的变更是正确对齐,不会破坏现有调用(参数带默认值 None
  • IluvatarCutlassWeightOnlyMoEMethod 未重写 apply_tp,自动继承新签名,行为正确

2. 文档更新

  • 添加 --extra-index-url 解决包安装依赖来源问题
  • git clone 添加 --recursive.git 后缀,源码编译步骤增加 pip3 install -r requirements_iluvatar.txt
  • PaddleOCR 版本说明从 commit hash 改为语义版本号 3.3.2,更清晰
  • PaddleOCRVL 调用添加 device="iluvatar_gpu" 参数,确保设备指定正确

3. 依赖变更

  • requirements_iluvatar.txt 新增 paddleocr[doc-parser]==3.3.2,与文档中描述一致

总体评价

变更内容清晰合理,MoE backend 接口对齐正确,文档改进实用。未发现阻塞性问题。

Copy link
Copy Markdown
Collaborator

@EmmonsCurse EmmonsCurse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ Skip check for iluvatar.

@EmmonsCurse EmmonsCurse merged commit 3b9d6c6 into PaddlePaddle:develop Apr 17, 2026
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants