[Iluvatar] fix ci error and update readme#7453
[Iluvatar] fix ci error and update readme#7453EmmonsCurse merged 1 commit intoPaddlePaddle:developfrom
Conversation
|
Thanks for your contribution! |
|
/skip-ci ci_hpu |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7453 +/- ##
==========================================
Coverage ? 74.22%
==========================================
Files ? 398
Lines ? 54947
Branches ? 8609
==========================================
Hits ? 40787
Misses ? 11426
Partials ? 2734
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PaddlePaddle-bot
left a comment
There was a problem hiding this comment.
🤖 AI Code Review |
2026-04-17 13:42 CST
📋 Review 摘要
PR 概述:修复 Iluvatar CI 报错,更新 README 安装文档,对齐 MoE backend 基类接口
变更范围:文档(中英文安装指南)、MoE 层 backend、依赖文件
影响面 Tag:Iluvatar OP Docs
📝 PR 规范检查
PR 描述中 Modifications/Usage/Accuracy Tests 均填写 "Pass",建议补充具体修改内容说明,便于后续追溯。
描述建议(可直接复制):
## Modifications
1. 更新中英文 Iluvatar 安装文档:添加 --extra-index-url、--recursive 参数、安装步骤结构优化
2. 对齐 IluvatarCutlassMoEMethod.apply_tp 签名与基类 MoEMethodBase,新增 fc1_latent_proj/fc2_latent_proj 支持
3. requirements_iluvatar.txt 新增 paddleocr[doc-parser]==3.3.2 依赖
问题
未发现阻塞性问题。
详细分析
1. apply_tp 签名对齐(fuse_moe_cutlass_iluvatar_backend.py)
- 基类
MoEMethodBase.apply_tp已定义fc1_latent_proj/fc2_latent_proj参数(默认None) - GPU cutlass backend、deepgemm backend 等均已实现该签名
- 本次 Iluvatar backend 的变更是正确对齐,不会破坏现有调用(参数带默认值
None) IluvatarCutlassWeightOnlyMoEMethod未重写apply_tp,自动继承新签名,行为正确
2. 文档更新
- 添加
--extra-index-url解决包安装依赖来源问题 git clone添加--recursive和.git后缀,源码编译步骤增加pip3 install -r requirements_iluvatar.txt- PaddleOCR 版本说明从 commit hash 改为语义版本号
3.3.2,更清晰 - PaddleOCRVL 调用添加
device="iluvatar_gpu"参数,确保设备指定正确
3. 依赖变更
requirements_iluvatar.txt新增paddleocr[doc-parser]==3.3.2,与文档中描述一致
总体评价
变更内容清晰合理,MoE backend 接口对齐正确,文档改进实用。未发现阻塞性问题。
EmmonsCurse
left a comment
There was a problem hiding this comment.
LGTM~ Skip check for iluvatar.
Motivation
修复ci报错,更新readme
Modifications
Pass
Usage or Command
Pass
Accuracy Tests
Pass
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.