Skip to content

[CI] Update worker log path to match new paddle log structure#7754

Merged
EmmonsCurse merged 2 commits intoPaddlePaddle:developfrom
EmmonsCurse:adapt_log_structure_change
May 9, 2026
Merged

[CI] Update worker log path to match new paddle log structure#7754
EmmonsCurse merged 2 commits intoPaddlePaddle:developfrom
EmmonsCurse:adapt_log_structure_change

Conversation

@EmmonsCurse
Copy link
Copy Markdown
Collaborator

@EmmonsCurse EmmonsCurse commented May 8, 2026

Motivation

The worker log directory structure has been updated, moving logs from:

  • log/workerlog.0
    to:
  • log/paddle/workerlog.0

The existing log grep command scans all files under the log directory, including environment backup files and default logs that may contain irrelevant or noisy "error" messages.

Related CI scripts need to be adapted to use the new log path.

Modifications

  • Updated worker log path references from:
    • log/workerlog.0
  • To:
    • log/paddle/workerlog.0
  • Updated the error grep command to exclude noisy log files:
    • backup_env.*.json
    • default.*.log
    • envlog.*
  • Adapted CI logic to align with the updated paddle log directory structure.

Usage or Command

N/A

Accuracy Tests

N/A

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented May 8, 2026

Thanks for your contribution!

@EmmonsCurse
Copy link
Copy Markdown
Collaborator Author

/skip-ci ci_iluvatar
/skip-ci ci_hpu

PaddlePaddle-bot

This comment was marked as outdated.

plusNew001
plusNew001 previously approved these changes May 8, 2026
@PaddlePaddle-bot

This comment was marked as off-topic.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@62afcc9). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #7754   +/-   ##
==========================================
  Coverage           ?   71.62%           
==========================================
  Files              ?      396           
  Lines              ?    55577           
  Branches           ?     8688           
==========================================
  Hits               ?    39805           
  Misses             ?    13032           
  Partials           ?     2740           
Flag Coverage Δ
GPU 71.62% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EmmonsCurse
Copy link
Copy Markdown
Collaborator Author

/skip-ci all

Copy link
Copy Markdown

@PaddlePaddle-bot PaddlePaddle-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Paddle-CI-Agent | pr_review | 2026-05-09 13:39:07

📋 Review 摘要

PR 概述:更新 CI 脚本中的 worker 日志路径,适配 Paddle 新日志目录结构(log/workerlog.0log/paddle/workerlog.0),同时优化 error grep 命令排除噪音日志文件
变更范围.github/workflows/scripts/(CI 脚本)、tests/(xpu_ci、metax_ci、e2e、model_loader)
影响面 Tag[CI] [XPU] [Metax]

📝 PR 规范检查

标题包含官方 Tag [CI],格式合规;描述结构完整,包含 Motivation、Modifications、Usage or Command、Accuracy Tests、Checklist 全部必填段落。✓

问题

未发现阻塞性问题。

❓ 疑问scripts/run_gpu_4cards.sh):原代码仅检查 log/log_0/workerlog.0,修改后变为同时检查两个路径:

  • ${REPO_ROOT}/log/paddle/workerlog.0(新增,去掉了 log_0 层级)
  • ${REPO_ROOT}/log/log_0/paddle/workerlog.0

其他脚本(如 tests/e2e/utils/serving_utils.py)分别保留了 log/log/log_0/ 两个层级,与此一致。请确认 4-cards 测试场景下,log/paddle/workerlog.0(不含 log_0)是否确实会产生日志?若该路径不会产生日志,建议去除避免打印空内容。

总体评价

整体变更逻辑清晰,18 个文件的路径更新统一一致。新增 --exclude 过滤 backup_env.*.jsondefault.*.logenvlog.* 等噪音文件的方案合理。仅对 run_gpu_4cards.sh 中新增的 log/paddle/workerlog.0 路径检查存有轻微疑问,不阻塞合入。

@EmmonsCurse EmmonsCurse merged commit af78f05 into PaddlePaddle:develop May 9, 2026
38 checks passed
@EmmonsCurse EmmonsCurse deleted the adapt_log_structure_change branch May 9, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants