[CI] Update worker log path to match new paddle log structure#7754
Conversation
|
Thanks for your contribution! |
|
/skip-ci ci_iluvatar |
This comment was marked as off-topic.
This comment was marked as off-topic.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7754 +/- ##
==========================================
Coverage ? 71.62%
==========================================
Files ? 396
Lines ? 55577
Branches ? 8688
==========================================
Hits ? 39805
Misses ? 13032
Partials ? 2740
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/skip-ci all |
ac5faec to
03f524c
Compare
PaddlePaddle-bot
left a comment
There was a problem hiding this comment.
🤖 Paddle-CI-Agent | pr_review |
2026-05-09 13:39:07
📋 Review 摘要
PR 概述:更新 CI 脚本中的 worker 日志路径,适配 Paddle 新日志目录结构(log/workerlog.0 → log/paddle/workerlog.0),同时优化 error grep 命令排除噪音日志文件
变更范围:.github/workflows/、scripts/(CI 脚本)、tests/(xpu_ci、metax_ci、e2e、model_loader)
影响面 Tag:[CI] [XPU] [Metax]
📝 PR 规范检查
标题包含官方 Tag [CI],格式合规;描述结构完整,包含 Motivation、Modifications、Usage or Command、Accuracy Tests、Checklist 全部必填段落。✓
问题
未发现阻塞性问题。
❓ 疑问(scripts/run_gpu_4cards.sh):原代码仅检查 log/log_0/workerlog.0,修改后变为同时检查两个路径:
${REPO_ROOT}/log/paddle/workerlog.0(新增,去掉了log_0层级)${REPO_ROOT}/log/log_0/paddle/workerlog.0
其他脚本(如 tests/e2e/utils/serving_utils.py)分别保留了 log/ 和 log/log_0/ 两个层级,与此一致。请确认 4-cards 测试场景下,log/paddle/workerlog.0(不含 log_0)是否确实会产生日志?若该路径不会产生日志,建议去除避免打印空内容。
总体评价
整体变更逻辑清晰,18 个文件的路径更新统一一致。新增 --exclude 过滤 backup_env.*.json、default.*.log、envlog.* 等噪音文件的方案合理。仅对 run_gpu_4cards.sh 中新增的 log/paddle/workerlog.0 路径检查存有轻微疑问,不阻塞合入。
Motivation
The worker log directory structure has been updated, moving logs from:
log/workerlog.0to:
log/paddle/workerlog.0The existing log grep command scans all files under the
logdirectory, including environment backup files and default logs that may contain irrelevant or noisy "error" messages.Related CI scripts need to be adapted to use the new log path.
Modifications
log/workerlog.0log/paddle/workerlog.0backup_env.*.jsondefault.*.logenvlog.*Usage or Command
N/A
Accuracy Tests
N/A
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.