[Cherry-Pick][CI] Restore self-hosted runners for GitHub workflows(#7906)#7909
Conversation
|
Thanks for your contribution! |
|
/skip-ci all |
PaddlePaddle-bot
left a comment
There was a problem hiding this comment.
🤖 Paddle-CI-Agent | pr_review |
2026-05-25 12:12:23
📋 Review 摘要
PR 概述:将 17 个 GitHub workflow 中的轻量级 job 从 ubuntu-latest 切换回 Paddle 自托管 runner(group: APPROVAL),并在各 job 首步添加工作区清理逻辑。
变更范围:.github/workflows/(CI 配置)
影响面 Tag:[CI]
问题
| 级别 | 文件 | 概述 |
|---|---|---|
| 🟡 建议 | .github/workflows/check-bypass.yml:69 |
per_page=100 限制,超过 100 个文件的 PR 可能漏检 |
📝 PR 规范检查
标题格式符合 Cherry-Pick 规范([Cherry-Pick][CI]),描述结构完整,各必填段落均已填写。[ ] Add unit tests. 未勾选且未说明原因,建议补充说明(如"CI 配置变更,无需单测")。
总体评价
整体变更清晰,目的明确,runner 切换和清理逻辑符合自托管 runner 最佳实践。主要关注点是 check-bypass.yml 中 API 分页限制,建议修复后合入。
|
|
||
| files=$(gh pr view ${{ github.event.pull_request.number }} --repo ${{ github.repository }} --json files --jq '.files[].path') | ||
| files=$(curl -s -H "Authorization: token $GITHUB_TOKEN" \ | ||
| "https://api.github.com/repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/files?per_page=100" \ |
There was a problem hiding this comment.
🟡 建议 per_page=100 限制了单次 API 返回的文件数量。
当 PR 变更文件数超过 100 时,files 变量将只包含前 100 个文件,导致 bypass 检查不完整,可能误判为可跳过。
建议修复方式:将 per_page 调整为 GitHub API 允许的最大值 300,并添加注释说明限制:
files=$(curl -s -H "Authorization: token $GITHUB_TOKEN" \
"https://api.github.com/repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/files?per_page=300" \
| jq -r '.[].filename')
# Note: GitHub API max per_page=300; PRs with >300 changed files still need pagination
CI报告基于以下代码生成(30分钟更新一次): 1 任务总览Required 任务当前无失败、无运行中、无等待项,按 required 维度不阻塞合并;本轮仅有 1 个 Optional 任务失败,失败项仅供参考。
2 任务状态汇总日志列说明:失败任务直接使用工具生成的日志链接;运行中任务链接到对应 Job。 2.1 Required任务 : 2/10 通过
2.2 可选任务 — 18/26 通过
3 失败详情(仅 required)无 required 失败任务。 4 补充说明
|
7e3be80 to
4ba8839
Compare
4ba8839 to
68b8857
Compare
Cherry-pick of #7906 (authored by @EmmonsCurse) to
release/2.6.devPR:#7906
Motivation
Recent updates introduced by PaddlePaddle/Paddle#79123 require corresponding CI-side adaptations in FastDeploy to keep workflow behavior.
Without synchronization, existing CI logic may become incompatible with the updated Paddle workflow implementation and introduce validation inconsistencies or execution issues.
Modifications
.github/workflowsback to the common Paddle self-hosted runner configuration:Usage or Command
N/A
Accuracy Tests
N/A
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.