[CI] Use prebuilt wheels and remove CI_METAX from release branches#7911
Conversation
|
Thanks for your contribution! |
|
/skip-ci ci_iluvatar |
PaddlePaddle-bot
left a comment
There was a problem hiding this comment.
🤖 Paddle-CI-Agent | pr_review |
2026-05-25 15:02:55
📋 Review 摘要
PR 概述:将 CI 安装的 xgrammar 和 torch 切换为预构建 wheel 包,并移除 release 分支的 CI_METAX 触发条件
变更范围:.github/workflows/、scripts/
影响面 Tag:[CI] [Metax]
问题
| 级别 | 文件 | 概述 |
|---|---|---|
| ❓ 疑问 | scripts/run_pre_ce.sh:13 |
triton 从注释态(3.2.0)升级为 3.4.0 并激活安装,PR 描述和脚本注释均未提及 |
📝 PR 规范检查
标题格式合规([CI] 为官方 Tag,格式 [Tag] 描述 符合规范)✓
描述结构完整,但有两处小问题需关注:
-
Modifications 漏提 triton:diff 中实际还将
triton-3.4.0从注释态激活(原注释版本为triton-3.2.0),PR 描述的 Modifications 仅提及 xgrammar 和 torch,建议补充 triton 的说明。 -
unit tests 未勾选且未说明原因:checklist 要求若不添加单测需在 PR 中说明原因,纯 CI 脚本变更虽无需单测,但建议在 checklist 项后补注说明,例如:
No unit tests needed for CI script-only changes。
总体评价
变更逻辑清晰,目标明确。主要建议是补充 triton 依赖的升级说明,无阻塞合入的问题。
| # https://paddle-qa.bj.bcebos.com/FastDeploy/xgrammar-0.1.19-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl | ||
| python -m pip install \ | ||
| https://paddle-qa.bj.bcebos.com/FastDeploy/torch-2.8.0-cp310-cp310-manylinux_2_28_x86_64.whl \ | ||
| https://paddle-qa.bj.bcebos.com/FastDeploy/triton-3.4.0-cp310-cp310-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl \ |
There was a problem hiding this comment.
❓ 疑问 triton 从注释状态(原 triton-3.2.0)升级为 triton-3.4.0 并激活安装,但 PR 描述的 Modifications 章节和上方脚本注释(第 10 行)均未提及此变更。
建议:
- 更新第 10 行注释:将
xgrammar==0.1.19 and torch==2.8.0改为xgrammar==0.1.19, torch==2.8.0 and triton==3.4.0 - 在 PR 描述 Modifications 中补充
triton==3.4.0的升级激活说明
CI报告基于以下代码生成(30分钟更新一次): 1 任务总览当前 required CI 无失败、无运行中、无等待任务;阻塞合并的任务已通过或跳过(bypass),建议通过。Optional 中有 1 个历史
2 任务状态汇总日志列说明:失败任务直接使用日志链接;运行中任务使用 Job 链接。 2.1 Required任务 : 4/10 通过
2.2 可选任务 — 29/36 通过
3 失败详情(仅 required)无 required 失败任务。 4 备注
|
Motivation
Installing
xgrammar==0.1.19triton==3.4.0andtorch==2.8.0directly from upstream sources in CI may introduce unnecessary installation overhead and instability.Using prebuilt wheel packages improves installation efficiency and environment consistency for CI workflows.
In addition, the
CI_METAXjob is no longer required forrelease/*branches and should be removed to reduce unnecessary CI resource consumption.Modifications
xgrammar==0.1.19torch==2.8.0triton==3.4.0to use prebuilt wheel files.
CI_METAXjob fromrelease/*branches.Usage or Command
N/A
Accuracy Tests
N/A
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.