-
Notifications
You must be signed in to change notification settings - Fork 43
【Hackathon 9th Sprint No.89】feat:Add extend logic for fake_perf_degrad #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
3619117923
wants to merge
7
commits into
PaddlePaddle:develop
Choose a base branch
from
3619117923:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
修改fake_perf_degrad及其后续逻辑
|
Thanks for your contribution! |
lixinqi
reviewed
Dec 9, 2025
lixinqi
reviewed
Dec 10, 2025
按照comment更新代码
lixinqi
reviewed
Dec 10, 2025
|
|
||
|
|
||
| def fake_perf_degrad(tolerance, error_code, type="default") -> str: | ||
| def fake_perf_degrad(tolerance, error_code, positive_tolerance_interpretation: PositiveToleranceInterpretation,) -> str: |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看起来没有格式化。你需要启用pre-commit工具
| 4: 4 | ||
| } | ||
|
|
||
| def is_error_tolerated(self, tolerance: int, base_error_code: str) -> bool: |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
两个类的这个函数的逻辑都非常混乱,这是因为你没有提供一个Errno枚举变量。
如果当前文件有MismatchExtendedErrorEnum
from enum import Enum
class MismatchExtendedErrorEnum(Enum):
kAccuracyViolation = 1
kValueTypeOrMetaMismatch = 2
kCompilationFailed = 3
kExecutionFailed = 4
@classmethod
def get_error_enum(cls, base_error_type: str) -> 'MismatchExtendedErrorEnum':
TODO本函数的主体逻辑将是一个>=而已。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
在fake_perf_degrad中修改了 extended 评估模式以符合要求,并修复了 verify_aggregated_params与samples_statistics的相关逻辑,与extend模式进行适配。在整体调用流程中增加了mode参数的调用链。在plot_ESt中提供了可选mode参数,支持extend功能。同时保证默认default参数时正常运行。
test:
使用fake.log进行测试,保证Aggregated与Microscopic的计算结果一致
Example:
Extra:
如有后续修改或赛事联系需求,请联系minazukihotaru710@163.com或直接在本PR下留言。