Skip to content

[Dy2Stat]Support to transform sequence assignments and multi-target assignments#24643

Merged
liym27 merged 2 commits intoPaddlePaddle:developfrom
liym27:support_sequence_assign_in_list_transformer
May 21, 2020
Merged

[Dy2Stat]Support to transform sequence assignments and multi-target assignments#24643
liym27 merged 2 commits intoPaddlePaddle:developfrom
liym27:support_sequence_assign_in_list_transformer

Conversation

@liym27
Copy link
Copy Markdown
Contributor

@liym27 liym27 commented May 19, 2020

As the title, support to transform sequence assignments and multi-target assignments to normal assignments.

Code transformation is as follows:

  • Before:
a, b = c, d
  • After:
a = c
b = d
  • Before:
a, b = c, d = x
  • After:
 c,d = x
 a = c
 b = d

Copy link
Copy Markdown
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

函数名要不要改成_parse_multi_target_assign,mul容易误解为乘法

Copy link
Copy Markdown
Contributor Author

@liym27 liym27 May 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,感谢建议!已修改

@liym27 liym27 force-pushed the support_sequence_assign_in_list_transformer branch from 24994e5 to 956df33 Compare May 20, 2020 03:29
Copy link
Copy Markdown
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liym27 liym27 merged commit 824572c into PaddlePaddle:develop May 21, 2020
@liym27 liym27 deleted the support_sequence_assign_in_list_transformer branch June 17, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants